Initial inclusion of go-ipfs
ClosedPublic
Actions

Authored by taaem on Jan 29 2018, 5:39 PM.

Details

Reviewers

JoshStrobl
DataDrake

Group Reviewers

Triage Team

Maniphest Tasks

T5361: IPFS

Commits

R4474:7aa060c19193: Initial inclusion of go-ipfs

Summary

Initial Inclusion of go-ipfs into the main repo. Resolves T5361.

Test Plan

Run ipfs init.
Then run ipfs daemon, then stopping the daemon again and running systemctl --user start ipfs.service, which also starts the daemon.

Repository

R4474 go-ipfs

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Additionally, please validate the systemd service and update the test plan accordingly.

package.yml
8	`network.base` is installed on everyone's system, meaning this would be installed automatically (which ya know, isn't good). Should be changed to `network.util` or `network.clients`
33–35	None of this is needed. We indicate the license in the SC and eopkg. We don't need the README. Changelogs are done via package updates and indicated in SC.

This revision now requires changes to proceed.Mar 3 2018, 10:26 AM

JoshStrobl retitled this revision from Initial Inclusion, T5361 to Initial inclusion of go-ipfs.Mar 3 2018, 10:27 AM

JoshStrobl edited the summary of this revision. (Show Details)

Abandoning due to lack of movement in over 30 days. Please feel free to re-open after addressing the issues previously raised.

@taaem, I am so sorry. I misread a date and closed this stupidly.

Please re-submit by running a arc diff --update D2132 after you make the changes.

Sorry again :(

Update the component and don't install unnecessary files

taaem edited the test plan for this revision. (Show Details)Aug 25 2018, 5:06 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2018, 8:30 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5122	4b825dc		Jan 29 2018, 5:39 PM	★	★
Diff 2	9161	4b825dc	Update the component and don't install unnecessary files	Aug 25 2018, 5:01 PM	★	★
Diff 3	9185	66c7be3	R4474:7aa060c191932e2bc4e423d97a8de4eae02f1076	Aug 25 2018, 8:30 PM	★	★