Page MenuHomeSolus

Initial inclusion of go-ipfs
ClosedPublic

Authored by taaem on Jan 29 2018, 5:39 PM.

Details

Summary

Initial Inclusion of go-ipfs into the main repo. Resolves T5361.

Test Plan

Run ipfs init.
Then run ipfs daemon, then stopping the daemon again and running systemctl --user start ipfs.service, which also starts the daemon.

Diff Detail

Repository
R4474 go-ipfs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

taaem created this revision.Jan 29 2018, 5:39 PM
JoshStrobl requested changes to this revision.Mar 3 2018, 10:26 AM
JoshStrobl added a subscriber: JoshStrobl.

Additionally, please validate the systemd service and update the test plan accordingly.

package.yml
8

network.base is installed on everyone's system, meaning this would be installed automatically (which ya know, isn't good). Should be changed to network.util or network.clients

33–35

None of this is needed.

  1. We indicate the license in the SC and eopkg.
  2. We don't need the README.
  3. Changelogs are done via package updates and indicated in SC.
This revision now requires changes to proceed.Mar 3 2018, 10:26 AM
JoshStrobl retitled this revision from Initial Inclusion, T5361 to Initial inclusion of go-ipfs.Mar 3 2018, 10:27 AM
JoshStrobl edited the summary of this revision. (Show Details)
DataDrake abandoned this revision.Mar 16 2018, 6:50 PM
DataDrake added a subscriber: DataDrake.

Abandoning due to lack of movement in over 30 days. Please feel free to re-open after addressing the issues previously raised.

@taaem, I am so sorry. I misread a date and closed this stupidly.

Please re-submit by running a arc diff --update D2132 after you make the changes.

Sorry again :(

taaem updated this revision to Diff 9161.Aug 25 2018, 5:02 PM

Update the component and don't install unnecessary files

taaem edited the test plan for this revision. (Show Details)Aug 25 2018, 5:06 PM
DataDrake accepted this revision.Aug 25 2018, 8:28 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2018, 8:30 PM
Closed by commit R4474:7aa060c19193: Initial inclusion of go-ipfs (authored by taaem, committed by DataDrake). · Explain Why
This revision was automatically updated to reflect the committed changes.