Page MenuHomeSolus

Initial working addition of ruby-multi-json
AbandonedPublic

Authored by debug on Jan 22 2018, 2:14 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Initial addition of ruby-multi-json which is a common interface to multiple JSON libraries.
It is required by the latest version of 'ruby-neovim'

Full ChangeLog is available here

  • Fix missing stdlib set dependency in oj adapter
Test Plan
  • Installed in a virtual machine running a fresh install of Solus.
  • Ran alongside 'ruby-neovim' and ran ':CheckHealth' in Neovim with everything reporting as correctly installed.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

debug created this revision.Jan 22 2018, 2:14 PM

Ditto feedback for D2054 and D2055

package.yml
8

There is now a programming.ruby component which these should all use now

18

There is now new macros for ruby:

%gem_build (from a .gemspec to build a .gem)
%gem_install (install a .gem file)

Try %gem_install as I'd like to know if it works (they haven't been widely tested so it will be good for me to know cases where they don't work)

This comment was removed by debug.
debug added a comment.Jan 23 2018, 1:07 AM

I've just tested building this package with '%gem_install' which builds the 'ruby-multi-gem' package successfully. However not the other two packages. I've added a screenshot which shows the error I'm getting with 'ruby-neovim' and 'ruby-msgpack' but not 'ruby-multi-json'

debug added a comment.Jan 23 2018, 1:12 AM

Scratch that It seems to be temperamental. I've just tried rebuilding 'ruby-multi-json' and get the same error now?

In D2056#30932, @debug wrote:

I've just tested building this package with '%gem_install' which builds the 'ruby-multi-gem' package successfully. However not the other two packages. I've added a screenshot which shows the error I'm getting with 'ruby-neovim' and 'ruby-msgpack' but not 'ruby-multi-json'

In theory, these macros will only work if you have required dependencies (rundeps as well I guess) in the builddeps.

The idea was that it would fail if deps weren't added (a safeguard to not having missing deps), cause it would try to download them as per that message (networking isn't allowed). I'm not sure if it is entirely feasible, but will have a look after landing a horde of patches

debug added a comment.Jan 23 2018, 1:21 AM

Okay that sounds good ill try build the packages again whenever you are ready. Thanks for the quick reply!

debug updated this revision to Diff 4944.Jan 24 2018, 12:39 AM

Changed to new 'programming.ruby' component

sunnyflunk abandoned this revision.Mar 23 2018, 11:11 PM

Ok, it turns out I landed this part of separating vagrant into 39 packages.

Also note that I landed it as ruby-multi_json so after the next sync you'll want to do this:

sudo eopkg rm ruby-multi-json
sudo eopkg install --reinstall ruby-neovim

Will land and fix the others to match the changes and validate the macros that I changed.