- Expand "when" test skippage to more perl versions
- Added test
Details
Details
- Reviewers
• sunnyflunk - Group Reviewers
Triage Team - Commits
- R2409:d11066c2221a: Update perl-try-tiny to 0.30
Installed perl-try-tiny and ran gtk-youtube-viewer.
Diff Detail
Diff Detail
- Repository
- R2409 perl-try-tiny
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Greetings, since you appear to be improving a lot of the perl stack (which is awesome), I will give you some tips in how to make them much easier for me to merge (and these comments apply across all the patches)
- When a patch depends on another, you must write it as Depends on DXXXX without any other text in-between. Don't need to know what the package is, Phab will do all the work in linking a stack for me to work from.
- Only add things to the changelog that are relevant to Solus. So that would mean excluding version release info, windows/mac specific changes.
- There's no need to repeat the git commit header in the summary section, and really doesn't need an additional Changelog header (it will have a summary header in the software center).
If you click (Show Details) above, I've done an example of cleaning up the commit (I removed the bit about perl 5.27.7 as it doesn't really apply to Solus). D1615 and D2021 are another couple of examples of nicely formatted commit messages
| package.yml | ||
|---|---|---|
| 2 | If you used the tooling, the version would have been '0.30' This is what it should be, otherwise it will report as 0.3 as in the pspec below (if you aren't using the tooling, you should be). | |