Details
- Reviewers
• sunnyflunk - Group Reviewers
Triage Team - Commits
- R3751:d5d353a29983: Update certbot to 0.21.0
Successfully generated a certificate
Diff Detail
- Repository
- R3751 certbot
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Are the builddep/rundep changes removed cause they are already deps of other packages? It's probably a good idea to comment about such changes
You are right, I should have commented the changes. I am working on rationalising the python dependencies and to add unit tests :
- For example, python-cryptography is a mandatory dependency for python-openssl. Until now, it wasn't set as a rundep of pyopenssl; instead it is added together with it in all the python packages that requires it. I have fixed this in D1551 and I'm cleaning this up when I update packages.
- Most builddeps are only required for unit tests, It happen to me to clean up these dependencies when unit tests are not present
- This package has a dependency with R3750 which already provides most of the dependencies I have removed.
- ...
One good thing is that unit tests greatly help finding out dependencies issues this is why I started sorting this out.
Yeah, there's definitely issues with perl/python rundeps. I'm sure you are using the setup.py which typically tells you the build and runtime requirements. Will need to check this still works from a clean install after it's merged
Note that this will require testing after merge on a clean install to ensure all the dep changes are working as intended.