Page MenuHomeSolus

Initial commit of kitty
ClosedPublic

Authored by livingsilver94 on Jan 15 2018, 9:37 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T4648: kitty
Commits
R4194:ccb2726615c5: Initial commit of kitty
Summary

The inclusion of kitty solves T4648

Test Plan

lsed various directories with a 2x2 grid of terminals.

Diff Detail

Repository
R4194 kitty
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Jan 15 2018, 9:37 PM

Add terminfo pattern

Remove useless xinput dependency (derp)

Just a note: kitty has tests, but some of them will fail because it needs a graphical environment.

Use proper terminfo path

Why is the terminfo separate?

Just followed Kitty's README on github, and it seemed logical to me.

bump for visibility.

Update to 0.8.0

Fix description indentation

Snuggle added a subscriber: Snuggle.

After installing freetype2 >= 21, this package and the terminfo package installs perfectly. Very happy with this. I hope it gets accepted for review soon!
sudo eopkg install https://archive.solus-project.com/unstable/f/freetype2/freetype2-2.8-21-1-x86_64.eopkg

Remove terminfo pattern

DataDrake accepted this revision.Mar 24 2018, 4:21 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 24 2018, 4:21 PM
DataDrake requested changes to this revision.Mar 24 2018, 4:26 PM

Actually, why can't you use our python ypkg macros?

This revision now requires changes to proceed.Mar 24 2018, 4:26 PM

Because the command must be python3 setup.py linux-package, not python3 setup.py build linux-package

DataDrake accepted this revision.Mar 24 2018, 5:57 PM

Looks good then. Had to ask ;)

This revision is now accepted and ready to land.Mar 24 2018, 5:57 PM
This revision was automatically updated to reflect the committed changes.