Page MenuHomeSolus
Differential D1964

Initial commit of kitty
ClosedPublic
Actions

Authored by livingsilver94 on Jan 15 2018, 9:37 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T4648: kitty
Commits
R4194:ccb2726615c5: Initial commit of kitty
Summary

The inclusion of kitty solves T4648

Test Plan

lsed various directories with a 2x2 grid of terminals.

Diff Detail

Repository
R4194 kitty
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 created this revision.Jan 15 2018, 9:37 PM
livingsilver94 updated this revision to Diff 4623.Jan 15 2018, 9:47 PM

Add terminfo pattern

livingsilver94 updated this revision to Diff 4626.Jan 15 2018, 9:58 PM

Remove useless xinput dependency (derp)

livingsilver94 added a comment.Jan 16 2018, 7:45 PM

Just a note: kitty has tests, but some of them will fail because it needs a graphical environment.

livingsilver94 updated this revision to Diff 4635.Jan 16 2018, 8:09 PM

Use proper terminfo path

sunnyflunk added a subscriber: sunnyflunk.Jan 17 2018, 2:21 AM

Why is the terminfo separate?

livingsilver94 added a comment.Jan 17 2018, 2:07 PM

Just followed Kitty's README on github, and it seemed logical to me.

livingsilver94 added a comment.Feb 13 2018, 8:16 PM

bump for visibility.

livingsilver94 updated this revision to Diff 5942.Mar 7 2018, 8:53 PM

Update to 0.8.0

livingsilver94 updated this revision to Diff 5943.Mar 7 2018, 8:55 PM

Fix description indentation

Snuggle awarded a token.Mar 9 2018, 6:08 PM
Snuggle added a subscriber: Snuggle.
Snuggle added a comment.Mar 13 2018, 6:19 PM

After installing freetype2 >= 21, this package and the terminfo package installs perfectly. Very happy with this. I hope it gets accepted for review soon!
sudo eopkg install https://archive.solus-project.com/unstable/f/freetype2/freetype2-2.8-21-1-x86_64.eopkg

livingsilver94 updated this revision to Diff 6172.Mar 15 2018, 5:10 PM

Remove terminfo pattern

DataDrake accepted this revision.Mar 24 2018, 4:21 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 24 2018, 4:21 PM
DataDrake requested changes to this revision.Mar 24 2018, 4:26 PM

Actually, why can't you use our python ypkg macros?

This revision now requires changes to proceed.Mar 24 2018, 4:26 PM
livingsilver94 added a comment.Mar 24 2018, 5:27 PM

Because the command must be python3 setup.py linux-package, not python3 setup.py build linux-package

DataDrake accepted this revision.Mar 24 2018, 5:57 PM

Looks good then. Had to ask ;)

This revision is now accepted and ready to land.Mar 24 2018, 5:57 PM
Closed by commit R4194:ccb2726615c5: Initial commit of kitty (authored by livingsilver94, committed by DataDrake). · Explain WhyMar 24 2018, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMMakefile (1 line)
AMabi_used_libs (13 lines)
AMpackage.yml (30 lines)
AMpspec_x86_64.xml (135 lines)

Diff 6450

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2019 Solus Project. The Solus logo is Copyright © 2016-2019 Solus Project. All Rights Reserved.