Differential D1938

Initial inclusion of T685 zotero
AbandonedPublic
Actions

Authored by ivanhoe1024 on Jan 12 2018, 11:02 AM.

Details

Reviewers

None

Group Reviewers

Triage Team

Summary

Inizial inclusion of Zotero 5.0.34 T685

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

ivanhoe1024 created this revision.Jan 12 2018, 11:02 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 12 2018, 11:02 AM

Here are some comments.

package.yml
5	The package should be made from source, not from the binary release https://github.com/zotero/zotero/releases
6	License is AGPL-3.0 https://www.zotero.org/support/dev/source_code#licensing
7	Should be `office.scientific` Use `eopkg lc` to list the components.
11	The dependencies should be alphabetized.
22	I don't think this is necessary. Also always use 5 digits for the permissions i.e: `00755`

In D1938#29367, @kyrios123 wrote:

Here are some comments.

Thank you for your comments, I totally missed the "build from source" thing. I will try to build the package as soon as I have some spare time (not before Jan 19th, unfortunately...). So if someone else in the meantime succeeds in building the package, please go on!