Page MenuHomeSolus
Differential D1884

Initial commit of milkytracker.
AbandonedPublic
Actions

Authored by ICA3DaR5 on Jan 5 2018, 4:22 PM.
Tags
None
Referenced Files
F11053534: D1884.id4521.diff
Thu, Aug 10, 11:25 PM
F11053533: D1884.id.diff
Thu, Aug 10, 11:25 PM
F11053532: D1884.id4440.diff
Thu, Aug 10, 11:25 PM
F11053531: D1884.id4439.diff
Thu, Aug 10, 11:25 PM
F11037872: D1884.diff
Wed, Aug 9, 9:21 PM
F11024538: D1884.diff
Tue, Aug 8, 10:08 PM
F10901192: D1884.id4440.diff
Jul 4 2023, 6:11 PM
F10901190: D1884.id.diff
Jul 4 2023, 6:10 PM
View All 17 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T4889: milkytracker
Summary

Initial commit of milkytracker.

Test Plan

Tested on Budgie. Missing .desktop file.

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ICA3DaR5 created this revision.Jan 5 2018, 4:22 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptJan 5 2018, 4:22 PM
ICA3DaR5 added a task: T4889: milkytracker.Jan 5 2018, 4:23 PM
ICA3DaR5 updated this revision to Diff 4440.Jan 5 2018, 4:29 PM
ICA3DaR5 edited the test plan for this revision. (Show Details)

Edit the Test Plan.

JoshStrobl requested changes to this revision.Jan 5 2018, 9:29 PM
JoshStrobl added a subscriber: JoshStrobl.

Missing .desktop file

Then you should probably make sure the necessary resources are installed. Look at https://github.com/milkytracker/MilkyTracker/tree/master/resources (probably in the tarball too)

This revision now requires changes to proceed.Jan 5 2018, 9:29 PM
ICA3DaR5 added a parent revision: D1899: Initial commit of milkytracker (fixed).Jan 7 2018, 12:40 AM
ICA3DaR5 removed a parent revision: D1899: Initial commit of milkytracker (fixed).
JoshStrobl added a comment.Jan 7 2018, 1:00 AM

Follow https://solus-project.com/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

JoshStrobl mentioned this in D1899: Initial commit of milkytracker (fixed).Jan 7 2018, 1:00 AM
ICA3DaR5 updated this revision to Diff 4521.Jan 7 2018, 11:23 AM
ICA3DaR5 edited edge metadata.

Added the .desktop file

JoshStrobl requested changes to this revision.Jan 27 2018, 12:48 PM
  1. Your test plan needs updating.
  2. There's no icon file shipped in this package as a fallback for icon themes that don't have milkytracker icons.
This revision now requires changes to proceed.Jan 27 2018, 12:48 PM
JoshStrobl abandoned this revision.Mar 3 2018, 9:19 AM

Closing due to lack of response.

cigh033 mentioned this in D2805: Initial commit of milkytracker.Apr 26 2018, 10:28 AM

Revision Contents
Changeset List

PathSize
1 line
9 lines
22 lines
37 lines

Diff 4521

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.