Page MenuHomeSolus
Differential D184

Patch eiskaltdcpp for libidn2
ClosedPublic
Actions

Authored by kyrios123 on May 23 2017, 7:50 PM.
Tags
None
Referenced Files
F11014214: D184.id452.diff
Fri, Aug 4, 9:54 PM
F10994670: D184.id343.diff
Wed, Jul 26, 12:00 AM
F10989752: D184.id338.diff
Mon, Jul 24, 5:09 PM
F10974490: D184.id452.diff
Sat, Jul 22, 12:47 AM
F10954112: D184.diff
Mon, Jul 17, 12:24 AM
F10931959: D184.id338.diff
Jul 11 2023, 10:42 PM
F10899146: D184.diff
Jul 3 2023, 12:06 PM
F10895642: D184.id343.diff
Jul 1 2023, 6:25 PM
View All 15 Files
Subscribers
ikey
kyrios123

Details

Reviewers
ikey
Group Reviewers
Triage Team
Maniphest Tasks
T3736: Replace libidn usage with libidn2 (co-installable)
Commits
R687:68d2c1f3f285: Patch eiskaltdcpp for libidn2
Summary

use GNU libidn2 instead of GNU libidn library

Ref task T3736

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Apply patch OK
  • Check build uses libidn2 OK
  • Install & Run application OK

Diff Detail

Repository
R687 eiskaltdcpp
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kyrios123 created this revision.May 23 2017, 7:50 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptMay 23 2017, 7:50 PM
kyrios123 edited the summary of this revision. (Show Details)May 23 2017, 8:13 PM
kyrios123 added a task: T3736: Replace libidn usage with libidn2 (co-installable).
kyrios123 updated this revision to Diff 343.May 23 2017, 8:18 PM

update release number

ikey added a subscriber: ikey.May 27 2017, 2:09 PM
ikey added inline comments.
pspec_x86_64.xml
39

pspec is out of sync?

ikey requested changes to this revision.May 27 2017, 2:12 PM

Only thing that needs changing is that pspec sync then it can go in. Other than that, fantastic work :)

This revision now requires changes to proceed.May 27 2017, 2:12 PM
kyrios123 updated this revision to Diff 452.May 27 2017, 5:25 PM
kyrios123 edited edge metadata.

fixed pspec. don't know what happened.

ikey accepted this revision.May 27 2017, 5:41 PM

LGTM!

This revision is now accepted and ready to land.May 27 2017, 5:41 PM
Closed by commit R687:68d2c1f3f285: Patch eiskaltdcpp for libidn2 (authored by kyrios123, committed by ikey). · Explain WhyMay 27 2017, 5:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 343

View Options

abi_used_libs

Loading...
View Options

files/switch-to-gnu-libidn2.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.