Page MenuHomeSolus

Initial version of python-coverage
ClosedPublic

Authored by kyrios123 on Dec 30 2017, 5:23 PM.
Tags
None
Referenced Files
F11048638: D1826.id4453.diff
Thu, Aug 10, 4:43 PM
F11048637: D1826.id4355.diff
Thu, Aug 10, 4:43 PM
F11048636: D1826.id4359.diff
Thu, Aug 10, 4:43 PM
F11048635: D1826.id.diff
Thu, Aug 10, 4:43 PM
F11048634: D1826.id4365.diff
Thu, Aug 10, 4:43 PM
F11034174: D1826.diff
Wed, Aug 9, 4:29 PM
F11010963: D1826.id4359.diff
Thu, Aug 3, 10:21 AM
F10993874: D1826.id4453.diff
Tue, Jul 25, 7:42 PM
Subscribers

Details

Summary

Inclusion of coverage in the repository

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Used in python-attrs test suite

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This has executables in /usr/bin/ so it would be best to do something like:

build      : |
    %python3_setup
    %python_setup

install    : |
    %python3_install
    for _f in $installdir/usr/bin/*; do
      mv -v $_f ${_f}3
    done
    %python_install

to ensure that executables are retained for both python 2 and python 3.

The installer handles this. I could replace some of the files by symbolic links though...

build@solus-budgie ~/YPKG/root/python-coverage/install/usr/bin $ ls -l
total 20
-rwxr-xr-x 1 build build 387 Dec 30 18:10 coverage
-rwxr-xr-x 1 build build 397 Dec 30 18:10 coverage-2.7
-rwxr-xr-x 1 build build 395 Dec 30 18:10 coverage-3.5
-rwxr-xr-x 1 build build 391 Dec 30 18:10 coverage2
-rwxr-xr-x 1 build build 389 Dec 30 18:10 coverage3

replace files with symbolic links

Thanks for that, I think we should try and be as consistent as possible with the executable names across packages, so I always try to go for x and x3 for example. I'm sure you'll have seen there's been much discussion over what should be standard. Also it's interesting that it's handled by the install script in this case, I've only ever seen that with one other python package, I'd just assumed that it wasn't, sorry about that!

This revision is now accepted and ready to land.Jan 5 2018, 9:43 PM
This revision was automatically updated to reflect the committed changes.