Update nettle to 3.4 & convert to ypkg
ClosedPublic
Actions

Authored by kyrios123 on Dec 29 2017, 6:31 PM.

Details

Reviewers

ikey
JoshStrobl

Commits

R2154:ca98b0990d59: Update nettle to 3.4 & convert to ypkg

Summary

Release notes available here

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Unit tests enabled
Installed on a VM seems to be still working fine

Diff Detail

Repository

R2154 nettle

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kyrios123 created this revision.Dec 29 2017, 6:31 PM

IMPORTANT: please read carefully below remarks

In the previous version libhogweed.so was available in both libhogweed AND libnettle-devel sub-packages. At the moment I placed this library in libnettle-devel as libhogweed.a and hogweed.pcare also in that sub-package. There is no dependency between libhogweed and libnettle-develso I am not very comfortable with this.

nettle-bin now has a dependency with libhogweed. I don't understand why and I haven't found a way to remove it as there shouldn't be such a dependency.

Perhaps this package wasn't a good candidate for a conversion to YPKG ?

kyrios123 mentioned this in T5629: Solus 'Spring' Repo Cleanup.Jan 25 2018, 5:08 PM

JoshStrobl requested changes to this revision.Jan 27 2018, 12:27 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
9–11	You're not really saving any work here nor does this particularly make sense. libhogweed would make sense in `security.library` rather than crypto, because it's a library.
46–52	Have you actually checked if this is needed vs being automatically added as rundeps as a result of the ABI used libs?

This revision now requires changes to proceed.Jan 27 2018, 12:27 PM

kyrios123 added inline comments.Jan 27 2018, 3:26 PM

package.yml

9–11

I just stay aligned to what currently exists. I did this to allow switching everything to another category just by updating one place.

Package found in Solus repository:
Name                : libhogweed, version: 3.3, release: 15
Summary             : Low level cryptographic library
Description         : The Nettle package contains the low-level cryptographic
                      library that is designed to fit easily in many contexts.
Licenses            : LGPL-3.0
Component           : security.crypto
Dependencies        : libnettle glibc gmp 
Distribution        : Solus, Dist. Release: 1
Architecture        : x86_64, Installed Size: 206.00 KB, Package Size: 130.00
                      KB
Reverse Dependencies:

I'll update this

46–52

Again I did reproduce the old behavior. That's how @ikey suggested me to work:
1/ convert "as-is"
2/ make wished changes in a next release

Apply suggested updates

JoshStrobl mentioned this in D3308: Update nettle to 3.4.Jul 17 2018, 9:43 AM

• sunnyflunk added a subscriber: • sunnyflunk.Jul 17 2018, 10:16 AM

• sunnyflunk added inline comments.

package.yml
53	If you are replicating, doesn't this require `unset LD_AS_NEEDED` prior to running `%configure`?

kyrios123 added inline comments.Jul 17 2018, 1:10 PM

package.yml
53	I get lot of (obviously non-blocking) errors during the checks when I unset it : `ERROR: ld.so: object 'libfakeroot.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.` Should I worry about this ?