Page MenuHomeSolus

Initial commit for python-extras
AbandonedPublic

Authored by curantes on Dec 28 2017, 7:59 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary

This package is a dependency for T5182

Signed-off-by: Matthias Eliasson <matthias.eliasson@gmail.com>

Test Plan

test installed, could not run unittests since the tests have dependeny for python-testtools which have this as depdency (dependency hell?!) :)

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

curantes created this revision.Dec 28 2017, 7:59 PM
kyrios123 added inline comments.
package.yml
26

Just for info you should use either

  • py.test3
  • pytest3
  • python3 pytest

Or eventually

  • python3 setup.py pytest
curantes updated this revision to Diff 4322.Dec 28 2017, 9:53 PM

Changed to pytest3 to be used when we can activate testing for this package for python3 build

curantes marked an inline comment as done.Dec 28 2017, 9:54 PM

@kyrios123 Thanks for the comment, I have done the changes you requested.

I just noticed the path should be fixed too... Below is what I use. It is often required to set PYTHONPATH. The -v parameter is for verbose and is optional

check      : |
    pushd $PKG_BUILD_DIR/py2build
        PYTHONPATH=$PWD py.test -v
    popd

    pushd $PKG_BUILD_DIR/py3build
        PYTHONPATH=$PWD py.test3 -v
    popd
curantes updated this revision to Diff 4325.Dec 28 2017, 10:20 PM

Add PYTHONPATH for the check run

DataDrake accepted this revision.Mar 24 2018, 4:43 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 24 2018, 4:43 PM
DataDrake requested changes to this revision.Mar 24 2018, 4:45 PM
DataDrake added inline comments.
package.yml
12

Same thing, needs to be python3 now

This revision now requires changes to proceed.Mar 24 2018, 4:45 PM
DataDrake abandoned this revision.May 11 2018, 12:21 PM

Closing due to lack of response in over 30 days.