Page MenuHomeSolus

Initial commit of insomnia
ClosedPublic

Authored by theSoenke on Dec 26 2017, 7:00 PM.

Details

Summary

The inclusion of insomnia fixes T3926

Google Analytics tracking is disabled by default (can still be activated in the settings). I think it is not the expected behavior for a user that a desktop application from the official/trusted repositories is tracking every event in the application.

Depends on D1889

Test Plan

Start application
Create requests to a REST API

Diff Detail

Repository
R3990 insomnia
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

theSoenke created this revision.Dec 26 2017, 7:00 PM
theSoenke edited the summary of this revision. (Show Details)Dec 26 2017, 7:06 PM
JoshStrobl requested changes to this revision.Dec 28 2017, 8:01 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
files/insomnia.desktop
5

You don't need to provide /usr/bin here.

package.yml
17

Not needed. It's a dependency of libgtk-2-devel

19

Not needed. Is a dep of xtst

29

I'd personally prefer lerna just be packaged separately to be honest.

38–39

Should specify modes for these.

40–41

You could just do cp -R packages/insomnia-app/build/dist/linux-unpacked/* $installdir/usr/share/insomnia/

This revision now requires changes to proceed.Dec 28 2017, 8:01 PM
theSoenke updated this revision to Diff 4331.Dec 28 2017, 11:26 PM
theSoenke edited edge metadata.

Remove unnecessary builddeps

Set directory modes

JoshStrobl requested changes to this revision.Jan 5 2018, 9:03 PM

Still want lerna to be packaged separately but otherwise looks good =)

This revision now requires changes to proceed.Jan 5 2018, 9:03 PM
theSoenke updated this revision to Diff 4477.Jan 5 2018, 10:32 PM
theSoenke edited edge metadata.
theSoenke marked 4 inline comments as done.

Add lerna dependency

theSoenke marked an inline comment as done.Jan 5 2018, 10:33 PM

Now lerna is a separate package :)

package.yml
29

I can package it, but shouldn't electron-builder then be packaged too?

No. electron-builder versions are going to range extensively on a per-application basis, where typically every new version involves downstreams to make changes, so it makes sense for those to be vendored it (via package.json). That's not likely the case with lerna.

JoshStrobl edited the summary of this revision. (Show Details)Jan 6 2018, 6:50 PM
JoshStrobl added a parent revision: D1889: Initial commit of lerna.
JoshStrobl requested changes to this revision.Jan 18 2018, 4:58 PM
JoshStrobl added inline comments.
package.yml
28

You're still doing an npm install lerna even though you added it as a builddep.

This revision now requires changes to proceed.Jan 18 2018, 4:58 PM
theSoenke updated this revision to Diff 4722.Jan 19 2018, 5:14 PM
theSoenke edited edge metadata.
theSoenke marked an inline comment as done.

Don't install lerna with npm

JoshStrobl accepted this revision.Jan 27 2018, 12:57 PM
This revision is now accepted and ready to land.Jan 27 2018, 12:57 PM
Closed by commit R3990:f3332289b68f: Initial commit of insomnia (authored by Sönke Behrendt <thesoenke@outlook.com>, committed by JoshStrobl). · Explain WhyJan 27 2018, 12:59 PM
This revision was automatically updated to reflect the committed changes.