| JoshStrobl |
| Triage Team |
The inclusion of insomnia fixes T3926
Google Analytics tracking is disabled by default (can still be activated in the settings). I think it is not the expected behavior for a user that a desktop application from the official/trusted repositories is tracking every event in the application.
Depends on D1889
Start application
Create requests to a REST API
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| files/insomnia.desktop | ||
|---|---|---|
| 5 | You don't need to provide /usr/bin here. | |
| package.yml | ||
| 17 | Not needed. It's a dependency of libgtk-2-devel | |
| 19 | Not needed. Is a dep of xtst | |
| 29 | I'd personally prefer lerna just be packaged separately to be honest. | |
| 38–39 | Should specify modes for these. | |
| 40–41 | You could just do cp -R packages/insomnia-app/build/dist/linux-unpacked/* $installdir/usr/share/insomnia/ | |
Now lerna is a separate package :)
| package.yml | ||
|---|---|---|
| 29 | I can package it, but shouldn't electron-builder then be packaged too? | |
No. electron-builder versions are going to range extensively on a per-application basis, where typically every new version involves downstreams to make changes, so it makes sense for those to be vendored it (via package.json). That's not likely the case with lerna.
| package.yml | ||
|---|---|---|
| 28 | You're still doing an npm install lerna even though you added it as a builddep. | |