Changelog available here
Apply security patches for: CVE-2017-18009 and CVE-2017-1000450
Signed-off-by: Pierre-Yves <pyu@riseup.net>
Details
Details
- Reviewers
• sunnyflunk - Group Reviewers
Triage Team - Commits
- R2235:e00a74446ec6: Update opencv to 3.4.0
- Successfully build retroshare against this version
- opencv_annotation --annotations=/tmp/text.txt --images=/tmp/images/ -> ok
Diff Detail
Diff Detail
- Repository
- R2235 opencv
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Is it possible to enable the extra modules of opencv (https://github.com/opencv/opencv_contrib) in this version? These libraries are dependencies of T1022.
Comment Actions
libhHalf only comes back as well as other libs if LD_AS_NEEDED is unset.
FWIW - I haven't encountered any issue with this lib gone until now.
Comment Actions
I would like to see this updated, but you'll have to make sure the revdeps all build
| package.yml | ||
|---|---|---|
| 61–62 | I'm not sure this is required anymore, please check the pkgconfig that it generates to see if -lippicv is an included Lib (think it was dropped in 3.2.0). | |
| package.yml | ||
|---|---|---|
| 61–62 | I don't find -lippicv in the generated opencv.pc # Package Information for pkg-config
prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}/lib64
includedir_old=${prefix}/include/opencv
includedir_new=${prefix}/include
Name: OpenCV
Description: Open Source Computer Vision Library
Version: 3.4.0
Libs: -L${exec_prefix}/lib64 -lopencv_dnn -lopencv_ml -lopencv_objdetect -lopencv_shape -lopencv_stitching -lopencv_superres -lopencv_videostab -lopencv_calib3d -lopencv_fe
atures2d -lopencv_highgui -lopencv_videoio -lopencv_imgcodecs -lopencv_video -lopencv_photo -lopencv_imgproc -lopencv_flann -lopencv_core
Libs.private: -ldl -lm -lpthread -lrt -L/usr/lib64 -lGL -lGLU -ltbb
Cflags: -I${includedir_old} -I${includedir_new} | |
| package.yml | ||
|---|---|---|
| 61–62 | Well my recommendation would be to remove the line and rebuild all the revdeps (that will confirm it isn't needed, 3.1.0 did have that line which made it necessary, but I noticed it dropped since 3.2.0). Hmmm revdeps seems small enough that I could even do it if need be xD | |
Comment Actions
@sunnyflunk everything builds fine against this version except digikam.
I tried with and without libippicv.a and the security patches.
Here are the logs : https://hastebin.com/ehukigoyek.scala
Comment Actions
Ok, keep security patches (they really shouldn't matter), nuke libippicv.a, it clearly doesn't do anything having it installed. Then try this patch on digikam, which hopefully fixes the build https://github.com/KDE/digikam/commit/6ea9e4289a88c167526d7cb6fdadadbbfc83e0b8