Page MenuHomeSolus

Update opencv to 3.4.0
ClosedPublic

Authored by kyrios123 on Dec 26 2017, 2:51 PM.

Details

Summary

Changelog available here

Apply security patches for: CVE-2017-18009 and CVE-2017-1000450

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
  • Successfully build retroshare against this version
  • opencv_annotation --annotations=/tmp/text.txt --images=/tmp/images/ -> ok

Diff Detail

Repository
R2235 opencv
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kyrios123 created this revision.Dec 26 2017, 2:51 PM
kyrios123 planned changes to this revision.Dec 26 2017, 3:22 PM

I need to fix things on this package

Yeah abi diff looks unhappy :)

kyrios123 updated this revision to Diff 4274.Dec 27 2017, 12:51 PM

python libs should come back

Still need to find out why libHalf doesn't want to come back too

EP01 added a subscriber: EP01.Dec 27 2017, 12:58 PM

You could maybe fix the license as well while you're here?

kyrios123 updated this revision to Diff 4275.Dec 27 2017, 1:24 PM

Use SPDX license code

kyrios123 updated this revision to Diff 4276.Dec 27 2017, 1:32 PM

remove lib suffix

Is it possible to enable the extra modules of opencv (https://github.com/opencv/opencv_contrib) in this version? These libraries are dependencies of T1022.

kyrios123 updated this revision to Diff 4293.Dec 28 2017, 4:15 PM

Use pkgconfig for jasper

kyrios123 updated this revision to Diff 4294.Dec 28 2017, 4:19 PM

libhHalf only comes back as well as other libs if LD_AS_NEEDED is unset.
FWIW - I haven't encountered any issue with this lib gone until now.

kyrios123 updated this revision to Diff 4400.Jan 2 2018, 10:11 PM
kyrios123 edited the summary of this revision. (Show Details)

Add some security patches

sunnyflunk requested changes to this revision.Jan 23 2018, 2:44 AM
sunnyflunk added a subscriber: sunnyflunk.

I would like to see this updated, but you'll have to make sure the revdeps all build

package.yml
60–61

I'm not sure this is required anymore, please check the pkgconfig that it generates to see if -lippicv is an included Lib (think it was dropped in 3.2.0).

This revision now requires changes to proceed.Jan 23 2018, 2:44 AM
kyrios123 requested review of this revision.Jan 24 2018, 5:42 PM
kyrios123 edited edge metadata.
kyrios123 added inline comments.
package.yml
60–61

I don't find -lippicv in the generated opencv.pc

# Package Information for pkg-config

prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}/lib64
includedir_old=${prefix}/include/opencv
includedir_new=${prefix}/include

Name: OpenCV
Description: Open Source Computer Vision Library
Version: 3.4.0
Libs: -L${exec_prefix}/lib64 -lopencv_dnn -lopencv_ml -lopencv_objdetect -lopencv_shape -lopencv_stitching -lopencv_superres -lopencv_videostab -lopencv_calib3d -lopencv_fe
atures2d -lopencv_highgui -lopencv_videoio -lopencv_imgcodecs -lopencv_video -lopencv_photo -lopencv_imgproc -lopencv_flann -lopencv_core
Libs.private: -ldl -lm -lpthread -lrt -L/usr/lib64 -lGL -lGLU -ltbb
Cflags: -I${includedir_old} -I${includedir_new}
sunnyflunk added inline comments.Jan 25 2018, 6:11 AM
package.yml
60–61

Well my recommendation would be to remove the line and rebuild all the revdeps (that will confirm it isn't needed, 3.1.0 did have that line which made it necessary, but I noticed it dropped since 3.2.0). Hmmm revdeps seems small enough that I could even do it if need be xD

@sunnyflunk everything builds fine against this version except digikam.
I tried with and without libippicv.a and the security patches.
Here are the logs : https://hastebin.com/ehukigoyek.scala

@sunnyflunk everything builds fine against this version except digikam.
I tried with and without libippicv.a and the security patches.
Here are the logs : https://hastebin.com/ehukigoyek.scala

Ok, keep security patches (they really shouldn't matter), nuke libippicv.a, it clearly doesn't do anything having it installed. Then try this patch on digikam, which hopefully fixes the build https://github.com/KDE/digikam/commit/6ea9e4289a88c167526d7cb6fdadadbbfc83e0b8

kyrios123 updated this revision to Diff 5021.Jan 25 2018, 10:26 PM

Nuke libippicv.a

This revision was automatically updated to reflect the committed changes.