Initial commit of shards
AbandonedPublic
Actions

Authored by Azphreal on Dec 25 2017, 10:08 AM.

Tags

None

Referenced Files

	F11011120: D1759.id4214.diff
	Thu, Aug 3, 12:57 PM

	F10983248: D1759.diff
	Sun, Jul 23, 1:35 PM

	F10943796: D1759.id.diff
	Fri, Jul 14, 9:01 PM

	F10839884: D1759.id4214.diff
	Jun 9 2023, 11:11 PM

	F10833831: D1759.diff
	Jun 7 2023, 3:35 AM

	F10776977: D1759.id.diff
	May 23 2023, 5:50 PM

	F10726500: D1759.id4214.diff
	May 9 2023, 7:31 AM

	F10726499: D1759.id.diff
	May 9 2023, 7:31 AM

View All 11 Files

Subscribers

DataDrake

JoshStrobl

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T4623: shards

Summary

Initial commit of shards for T4623.

Test Plan

Initialise new project
Add minitest.cr dependency to project
Build simple "hello world" program

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

Azphreal created this revision.Dec 25 2017, 10:08 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 25 2017, 10:08 AM

Azphreal added a task: T4623: shards.Dec 25 2017, 10:08 AM

DataDrake added a subscriber: DataDrake.Mar 24 2018, 4:48 PM

DataDrake added inline comments.

package.yml
11	Why does this need networking?

Azphreal added inline comments.Mar 25 2018, 12:24 AM

package.yml
11	In the `check` step it runs itself to install dependencies (from the internet) for its tests. That's the only time it requires networking, though.

Networking bit is fine.

package.yml
7	Should be `programming.tools`

This revision now requires changes to proceed.May 19 2018, 1:56 PM

At some point down the line integration tests have started failing in the chroot (passing otherwise). Given that I haven't bumped shards since initial commit, has something changed in solbuild's backend that might cause them to fail? Otherwise I'll just disable them.