Page MenuHomeSolus

Initial commit of shards
AbandonedPublic

Authored by Azphreal on Dec 25 2017, 10:08 AM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T4623: shards
Summary

Initial commit of shards for T4623.

Test Plan
  • Initialise new project
  • Add minitest.cr dependency to project
  • Build simple "hello world" program

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Azphreal created this revision.Dec 25 2017, 10:08 AM
DataDrake added inline comments.
package.yml
11

Why does this need networking?

Azphreal added inline comments.Mar 25 2018, 12:24 AM
package.yml
11

In the check step it runs itself to install dependencies (from the internet) for its tests. That's the only time it requires networking, though.

JoshStrobl requested changes to this revision.May 19 2018, 1:56 PM
JoshStrobl added a subscriber: JoshStrobl.

Networking bit is fine.

package.yml
7

Should be programming.tools

This revision now requires changes to proceed.May 19 2018, 1:56 PM
Azphreal added a comment.EditedMay 19 2018, 2:43 PM

At some point down the line integration tests have started failing in the chroot (passing otherwise). Given that I haven't bumped shards since initial commit, has something changed in solbuild's backend that might cause them to fail? Otherwise I'll just disable them.

DataDrake abandoned this revision.Oct 20 2018, 4:10 PM

Closing due to lack of activity in over 30 days.