Page MenuHomeSolus

Add ramme
AbandonedPublic

Authored by flyingP0tat0 on Dec 24 2017, 11:40 PM.
Tags
None
Referenced Files
F11023932: D1758.diff
Tue, Aug 8, 5:41 PM
F11005819: D1758.diff
Tue, Aug 1, 10:15 AM
F10950685: D1758.id4212.diff
Sun, Jul 16, 8:17 AM
F10896463: D1758.id4249.diff
Jul 2 2023, 12:23 AM
F10896455: D1758.id.diff
Jul 2 2023, 12:23 AM
F10877578: D1758.diff
Jun 20 2023, 9:02 PM
F10865717: D1758.diff
Jun 17 2023, 12:39 PM
F10844957: D1758.id4249.diff
Jun 10 2023, 10:34 PM

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T2434: ramme
Summary

fixes T2434

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

JoshStrobl requested changes to this revision.EditedMar 17 2018, 2:26 PM
JoshStrobl added a subscriber: JoshStrobl.
  1. You should be generating the package.yml using the instructions on our Packaging Practices page.
  2. /var/lib isn't an acceptable path.
  3. You offer no appropriate summary or test plan, both of which we require.

Not gonna review further until at least the two above issues are addressed.

This revision now requires changes to proceed.Mar 17 2018, 2:26 PM
DataDrake added a subscriber: DataDrake.

Closing due to lack of response in over 30 days.