Page MenuHomeSolus

Add ramme
AbandonedPublic

Authored by flyingP0tat0 on Dec 24 2017, 11:40 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T2434: ramme
Summary

fixes T2434

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
flyingP0tat0 created this revision.Dec 24 2017, 11:40 PM

Update to use icon

Remove unnecessary modes

JoshStrobl requested changes to this revision.EditedMar 17 2018, 2:26 PM
JoshStrobl added a subscriber: JoshStrobl.
  1. You should be generating the package.yml using the instructions on our Packaging Practices page.
  2. /var/lib isn't an acceptable path.
  3. You offer no appropriate summary or test plan, both of which we require.

Not gonna review further until at least the two above issues are addressed.

This revision now requires changes to proceed.Mar 17 2018, 2:26 PM
DataDrake abandoned this revision.May 11 2018, 12:22 PM
DataDrake added a subscriber: DataDrake.

Closing due to lack of response in over 30 days.