Differential D1744

Initial commit of working eopkg completions for fish
AbandonedPublic
Actions

Authored by debug on Dec 22 2017, 7:45 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Summary

Full Changelog

Added definitions for latest commands added to eopkg in release.
Fixed typo which caused almost half the completions to not function.
Migrated to GitHub from SourceForge.

Test Plan

Made sure the completion definitions exist in '/usr/share/fish/completions/eopkg.fish'.
Tested using Fish shell and completions work as expected.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

debug created this revision.Dec 22 2017, 7:45 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 22 2017, 7:45 PM

Why is this a separate project and not just something we ship with eopkg? Also you should be following instructions available here for generating the package.yml.

This revision now requires changes to proceed.Mar 17 2018, 2:35 PM

Thanks for the link to the packaging practices. I have given them a good read over; the yauto.py script does indeed make the job a lot easier. I see no reason that they can't be shipped with eopkg it defiantly doesn't need to be a separate project.

No need to have a separate package