Page MenuHomeSolus

Initial commit of electronic-wechat
ClosedPublic

Authored by xulongwu4 on Dec 19 2017, 1:13 AM.

Details

Summary

Initial commit of electronic-wechat and resolve T1081

Test Plan

Installed the application on my desktop, logged in using my account and sent messages to my friends.

Diff Detail

Repository
R4300 electronic-wechat
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
xulongwu4 created this revision.Dec 19 2017, 1:13 AM

Thanks for packaging this! I have only one request for the description to be more informative: WeChat is a Chinese multi-purpose social media, instant messaging and VoIP mobile application software developed by Tencent. In order to use the unofficial desktop client electronic-wechat, you must sync your mobile WeChat account by scanning a QR code. While the application itself is open source, the protocol itself is proprietary and conversations are intercepted and censored. Use with caution.

xulongwu4 updated this revision to Diff 4121.Dec 19 2017, 3:03 PM

Update the description per the request of @baimafeima

xulongwu4 edited the summary of this revision. (Show Details)Dec 19 2017, 3:05 PM

I tested the build. Functionality-wise everything works fine. Thanks a lot.

It's a bit odd that the actual binary executable is in /usr/share/electronic-wechat/electronic-wechat, symlinked to /usr/bin/electronic-wechat.

Since wechat are primarily used by Chinese users, zh_CN translation in the .desktop file would be nice. Please consider using this file:
https://github.com/hashhsah/3rd-party/blob/master/network/im/electronic-wechat/files/electronic-wechat.desktop

xulongwu4 updated this revision to Diff 4155.Dec 21 2017, 6:06 AM

Update the desktop file per the request of @hashhsah.

xulongwu4 updated this revision to Diff 5982.Mar 9 2018, 6:03 PM

Clean the package.yml file

kyrios123 added inline comments.
package.yml
15

the pkgconfig() should go first

xulongwu4 updated this revision to Diff 5984.Mar 9 2018, 6:11 PM

Move the pkgconfig stuff first in builddeps

xulongwu4 updated this revision to Diff 6729.Apr 13 2018, 2:41 PM

Update the package.yml file

  • Reorder the build dependencies
  • Set correct permission bits for directory $installdir/usr/share/electronic-wechat
  • Install app icon to $installdir/usr/share/pixmaps
JoshStrobl requested changes to this revision.May 19 2018, 1:52 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
9

Honestly I'd just use the following part of the description: "WeChat is a Chinese multi-purpose social media, instant messaging and VoIP mobile application software developed by Tencent." given the macOS part is completely irrelevant, better is subjective, etc.

This revision now requires changes to proceed.May 19 2018, 1:52 PM

I'm not sure what you mean by "macOS part". I think it'll be important to mention that this is an independently developed hence unofficial desktop client which only functions in conjunction with having WeChat installed on a mobile phone (similar to Kontalk). A new user may also be misled into thinking that it is entirely open source which it is not. Only the application is open source, the protocol is proprietary.

xulongwu4 updated this revision to Diff 7463.May 31 2018, 3:02 PM

Update package.yml

JoshStrobl accepted this revision.Jun 4 2018, 3:30 PM
This revision is now accepted and ready to land.Jun 4 2018, 3:30 PM
This revision was automatically updated to reflect the committed changes.