Initial commit of electronic-wechat and resolve T1081
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T1081: Electronic WeChat (Chinese IM app)
- Commits
- R4300:3ccf5da868a3: Initial commit of electronic-wechat
Installed the application on my desktop, logged in using my account and sent messages to my friends.
Diff Detail
Diff Detail
- Repository
- R4300 electronic-wechat
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks for packaging this! I have only one request for the description to be more informative: WeChat is a Chinese multi-purpose social media, instant messaging and VoIP mobile application software developed by Tencent. In order to use the unofficial desktop client electronic-wechat, you must sync your mobile WeChat account by scanning a QR code. While the application itself is open source, the protocol itself is proprietary and conversations are intercepted and censored. Use with caution.
Comment Actions
I tested the build. Functionality-wise everything works fine. Thanks a lot.
It's a bit odd that the actual binary executable is in /usr/share/electronic-wechat/electronic-wechat, symlinked to /usr/bin/electronic-wechat.
Since wechat are primarily used by Chinese users, zh_CN translation in the .desktop file would be nice. Please consider using this file:
https://github.com/hashhsah/3rd-party/blob/master/network/im/electronic-wechat/files/electronic-wechat.desktop
| package.yml | ||
|---|---|---|
| 15 | the pkgconfig() should go first | |
Comment Actions
Update the package.yml file
- Reorder the build dependencies
- Set correct permission bits for directory $installdir/usr/share/electronic-wechat
- Install app icon to $installdir/usr/share/pixmaps
| package.yml | ||
|---|---|---|
| 9 | Honestly I'd just use the following part of the description: "WeChat is a Chinese multi-purpose social media, instant messaging and VoIP mobile application software developed by Tencent." given the macOS part is completely irrelevant, better is subjective, etc. | |
Comment Actions
I'm not sure what you mean by "macOS part". I think it'll be important to mention that this is an independently developed hence unofficial desktop client which only functions in conjunction with having WeChat installed on a mobile phone (similar to Kontalk). A new user may also be misled into thinking that it is entirely open source which it is not. Only the application is open source, the protocol is proprietary.