Initial commit of cerebro and resolve T5193
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Maniphest Tasks
- T5193: Cerebro App
- Commits
- R4090:c4f7ce70aff8: Initial commit of cerebro
Installed cerebro on my Solus budgie and did a few search. Things work as expected.
Diff Detail
Diff Detail
- Repository
- R4090 cerebro
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| files/cerebro.desktop | ||
|---|---|---|
| 5 | Only needs to be Exec=cerebro | |
| package.yml | ||
| 14 | This should be after the pkgconfigs. | |
| 23 | You're already in $workdir, just run yarn. | |
| 24 | Would prefer this be: pushd app yarn popd | |
| 25 | Can just be yarn run package | |
| 27–28 | Have Cerebro be lowercase for consistency. | |
| 30 | Can merge the flags, they shouldn't need to be separated. | |
| 31 | Should change to cerebro from Cerebro as per other comment. | |
| 32–33 | Newline and comment not really necessary. It's pretty obvious. | |
| 34 | -D -m 00644 can just be -Dm00644 | |
| 38 | -D -m 00644 can just be -Dm00644 | |