Page MenuHomeSolus

Switch to i3lock-color for T4589
ClosedPublic

Authored by feskyde on Dec 15 2017, 7:48 AM.

Details

Summary

This fork includes these new features:

  • Color options for the following:
    • Verification ring
    • Interior ring color
    • Ring interior line color
    • Key highlight color
    • Backspace highlight color
    • Text colors for most/all strings
    • Changing all of the above depending on PAM's authentication status
  • Blurring the current screen and using that as the lock background
  • Showing a clock in the indicator
  • refreshing on a timer, instead of on each keypress
  • Positioning the various UI elements
  • Changing the ring radius and thickness, as well as text size
  • A new bar indicator, which replaces the ring indicator with its own set of options
    • An experimental thread for driving the redraw ticks, so that things like the bar/clock still update when PAM is blocking

Resolves T4589.

Signed-off-by: Federico Damián Schonborn <federicodamiansch@gmail.com>

Test Plan

Executed it a few times, I was capable of unlocking my desktop normally.

Diff Detail

Repository
R1440 i3lock
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

feskyde created this revision.Dec 15 2017, 7:48 AM
JoshStrobl requested changes to this revision.Dec 15 2017, 7:56 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
8–10

Let's get the summary and descriptions updated to indicate we're using the color fork. Something like "We're using PandorasFox's color fork for improved customization."

This revision now requires changes to proceed.Dec 15 2017, 7:56 AM
feskyde updated this revision to Diff 3990.Dec 15 2017, 8:08 AM
feskyde edited edge metadata.

Added fork aclaration line

Hold a sec...

feskyde updated this revision to Diff 3991.Dec 15 2017, 8:29 AM

Use the git source because it needs a git history to detect this as a "release" build.

JoshStrobl requested changes to this revision.Dec 15 2017, 9:54 AM
JoshStrobl added inline comments.
package.yml
5

Not technically necessary bit still would prefer the .git at the end of the git URL.

This revision now requires changes to proceed.Dec 15 2017, 9:54 AM
feskyde updated this revision to Diff 3993.Dec 15 2017, 10:06 AM
feskyde edited edge metadata.

Add .git suffix to source

JoshStrobl accepted this revision.Dec 15 2017, 10:10 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Dec 15 2017, 10:10 AM
JoshStrobl edited the summary of this revision. (Show Details)Dec 15 2017, 10:13 AM
This revision was automatically updated to reflect the committed changes.