Page MenuHomeSolus
Differential D1534

Initial commit of GtkD
ClosedPublic
Actions

Authored by • tristan957 on Dec 3 2017, 2:56 AM.
Tags
None
Referenced Files
F10982367: D1534.diff
Sun, Jul 23, 10:07 AM
F10981717: D1534.diff
Sun, Jul 23, 7:50 AM
F10828921: D1534.id4190.diff
Jun 4 2023, 10:41 AM
F10819192: D1534.id3766.diff
Jun 1 2023, 6:31 PM
F10818203: D1534.diff
Jun 1 2023, 11:47 AM
F10766175: D1534.id5614.diff
May 19 2023, 5:03 PM
F10738120: D1534.id5613.diff
May 13 2023, 9:33 AM
F10726715: D1534.id3766.diff
May 9 2023, 12:18 PM
View All 17 Files
Subscribers
DataDrake
joebonrichie

Details

Reviewers
DataDrake
joebonrichie
Group Reviewers
Triage Team
Maniphest Tasks
T2402: GtkD
Commits
R1101:7cabaf5c8205: Initial inclusion of gtkd
Summary

Initial inclusion of GtkD

Fixes T2402

Test Plan

Ran a simple GtkD program

Diff Detail

Repository
R1101 gtkd
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• tristan957 created this revision.Dec 3 2017, 2:56 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 3 2017, 2:56 AM
DataDrake requested changes to this revision.Dec 17 2017, 9:08 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
2

Why not just gtkd?

This revision now requires changes to proceed.Dec 17 2017, 9:08 PM
• tristan957 added a comment.Dec 17 2017, 9:23 PM

I will change that later today. I felt like I saw it written that way but doesn't matter.

• tristan957 updated this revision to Diff 4190.Dec 22 2017, 10:43 PM
• tristan957 edited edge metadata.

gtk-d -> gtkd

• tristan957 marked an inline comment as done.Dec 22 2017, 10:46 PM

@DataDrake rename complete

curantes edited the summary of this revision. (Show Details)Dec 25 2017, 3:44 PM
curantes added a task: T2402: GtkD.
curantes mentioned this in T2402: GtkD.Dec 25 2017, 3:50 PM
joebonrichie requested changes to this revision.Dec 26 2017, 5:14 PM
joebonrichie added a subscriber: joebonrichie.

Outdated, latest release is 3.7.3
Only producing static libs, even though you specified shared so not sure whats going on there. We would like .so files instead of .a files.
After fixing the package to produce shared libraries, you may need to set libsplit : no so not only a -devel subpackage is produced.

You might find this spec file from opensuse useful
https://build.opensuse.org/package/view_file/devel:languages:D/gtkd/gtkd.spec?expand=1

If tilix can be built with this as a local dependency for testing that would be great (dub add-local GtkD-3.7.3 & pkgconfig(gtkd-3))

That's quite a lot there so give us a shout if you need a hand with anything :)

This revision now requires changes to proceed.Dec 26 2017, 5:14 PM
• tristan957 marked an inline comment as not done.Dec 26 2017, 5:33 PM

I'll give it a look once I get back into town!

• tristan957 marked an inline comment as done.Jan 31 2018, 5:12 AM

Gonna look into this again tonight

• tristan957 added a comment.Jan 31 2018, 5:23 AM

Something I am noticing on the opensuse build file is the dcflags: DCFLAGS='-O -release -inline -boundscheck=off -w -g'. Should we do something similar with the common flags?

• tristan957 added a comment.Jan 31 2018, 5:34 AM

@joebonrichie how can I split the packages into things like libvted-devel, libgstreamerd-devel, etc.? Still not really clear on that

joebonrichie added a comment.Jan 31 2018, 10:51 AM

@tristan957 i would say look at vala's package.yml - the ^vala pattern means the resulting package will be called vala. If you exclude the ^ symbol e.g. docs the resulting package will be called vala-docs.

• tristan957 added a comment.Feb 8 2018, 9:13 PM

So still getting just the single devel package, but I am not getting .so and .a files. Is this still wrong? Also libsplit = no doesn't seem to be helping

joebonrichie added a comment.Feb 8 2018, 9:18 PM

Try replacing shared with shared-gstreamer shared-gtkd shared-gtkdgl shared-peas shared-sv shared-vte

joebonrichie mentioned this in D1452: Update dmd to 2.077.0 and fix phobos support.Feb 21 2018, 9:52 PM
joebonrichie mentioned this in R638:58304684fe86: Update dmd to 2.077.0 and fix phobos support.Feb 21 2018, 10:03 PM
joebonrichie updated this revision to Diff 5611.Feb 21 2018, 10:04 PM

Provide shared libraries

joebonrichie updated this revision to Diff 5613.Feb 21 2018, 10:15 PM

Fix rel no
Remove empty file

joebonrichie accepted this revision.Feb 21 2018, 10:30 PM

So in the future I might split this package into gtkd, gtkd-vte and so on but for now let's just have a working package.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 21 2018, 10:32 PM
Closed by commit R1101:7cabaf5c8205: Initial inclusion of gtkd (authored by joebonrichie). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
5 lines
32 lines
50 lines

Diff 5614

View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.