Page MenuHomeSolus

Initial commit of GtkD
ClosedPublic

Authored by tristan957 on Dec 3 2017, 2:56 AM.

Details

Summary

Initial inclusion of GtkD

Fixes T2402

Test Plan

Ran a simple GtkD program

Diff Detail

Repository
R1101 gtkd
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tristan957 created this revision.Dec 3 2017, 2:56 AM
DataDrake requested changes to this revision.Dec 17 2017, 9:08 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
2

Why not just gtkd?

This revision now requires changes to proceed.Dec 17 2017, 9:08 PM

I will change that later today. I felt like I saw it written that way but doesn't matter.

tristan957 edited edge metadata.

gtk-d -> gtkd

tristan957 marked an inline comment as done.Dec 22 2017, 10:46 PM

@DataDrake rename complete

curantes edited the summary of this revision. (Show Details)Dec 25 2017, 3:44 PM
curantes added a task: T2402: GtkD.
joebonrichie requested changes to this revision.Dec 26 2017, 5:14 PM
joebonrichie added a subscriber: joebonrichie.

Outdated, latest release is 3.7.3
Only producing static libs, even though you specified shared so not sure whats going on there. We would like .so files instead of .a files.
After fixing the package to produce shared libraries, you may need to set libsplit : no so not only a -devel subpackage is produced.

You might find this spec file from opensuse useful
https://build.opensuse.org/package/view_file/devel:languages:D/gtkd/gtkd.spec?expand=1

If tilix can be built with this as a local dependency for testing that would be great (dub add-local GtkD-3.7.3 & pkgconfig(gtkd-3))

That's quite a lot there so give us a shout if you need a hand with anything :)

This revision now requires changes to proceed.Dec 26 2017, 5:14 PM
tristan957 marked an inline comment as not done.Dec 26 2017, 5:33 PM

I'll give it a look once I get back into town!

tristan957 marked an inline comment as done.Jan 31 2018, 5:12 AM

Gonna look into this again tonight

Something I am noticing on the opensuse build file is the dcflags: DCFLAGS='-O -release -inline -boundscheck=off -w -g'. Should we do something similar with the common flags?

@joebonrichie how can I split the packages into things like libvted-devel, libgstreamerd-devel, etc.? Still not really clear on that

@tristan957 i would say look at vala's package.yml - the ^vala pattern means the resulting package will be called vala. If you exclude the ^ symbol e.g. docs the resulting package will be called vala-docs.

So still getting just the single devel package, but I am not getting .so and .a files. Is this still wrong? Also libsplit = no doesn't seem to be helping

Try replacing shared with shared-gstreamer shared-gtkd shared-gtkdgl shared-peas shared-sv shared-vte

Provide shared libraries

Fix rel no
Remove empty file

joebonrichie accepted this revision.Feb 21 2018, 10:30 PM

So in the future I might split this package into gtkd, gtkd-vte and so on but for now let's just have a working package.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 21 2018, 10:32 PM
This revision was automatically updated to reflect the committed changes.