Differential D1533

libnetfilter_queue 1.0.3
AbandonedPublic
Actions

Authored by czb on Dec 2 2017, 10:03 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T5036: NetfilterQueue

Summary

libnetfilter_queue is a userspace library providing an API to packets that have been queued by the kernel packet filter. Depends on D1309, resolves T5036.

Test Plan

Installed NetfilterQueue successfully.

Diff Detail

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

czb created this revision.Dec 2 2017, 10:03 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 2 2017, 10:03 PM

Trying to fix messed up description.

Actually newer version of this library is available. Changing 1.0.2 to 1.0.3.

czb retitled this revision from libnetfilter_queue 1.0.2 to libnetfilter_queue 1.0.3.Dec 2 2017, 10:18 PM

JoshStrobl requested changes to this revision.Dec 28 2017, 6:08 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
9	You need to be using the generating a package.yml instructions and not changing its characters.
14–15	Spacing should be 4 and you should be using the pkgconfigs. Look at https://solus-project.com/articles/packaging/packaging-practices/en/#using-pkgconfig-dependencies

This revision now requires changes to proceed.Dec 28 2017, 6:08 PM

I no longer have the git repository I submitted the package from. Should I just upload a diff file?

@czb Going to mark this as abandoned. You can download the git formatted patch of this using arc export --git --diff 3765 and apply it using git apply.

Should I make another package submission then?

Revision Contents
Changeset List

		Path
A	M	Makefile (1 line)
A	M	abi_symbols (78 lines)
A	M	abi_used_libs (3 lines)
A	M	package.yml (21 lines)
A	M	pspec_x86_64.xml (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3763	4b825dc		Dec 2 2017, 10:03 PM	★	★
Diff 2	3764	4b825dc	Trying to fixed messed up description.	Dec 2 2017, 10:04 PM	★	★
Diff 3	3765	4b825dc	Actually newer version of this library is available. Changing 1.0.2 to 1.0.3.	Dec 2 2017, 10:18 PM	★	★