Update python-attrs to 17.3.0
ClosedPublic
Actions

Authored by EP01 on Nov 30 2017, 8:10 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R2555:13854db59d3b: Update python-attrs to 17.3.0

Summary

Breaking Change

Attributes are not defined on the class body anymore.

This means that if you define a class C with an attribute x, the class will not have an attribute x for introspection anymore. Instead of C.x, use attr.fields(C).x or look at C.__attrs_attrs__. The old behaviour has been deprecated since version 16.1. (#253)

Full Changelog

Test Plan

Tested with pytest and qutebrowser.

Diff Detail

Repository

R2555 python-attrs

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

EP01 created this revision.Nov 30 2017, 8:10 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 30 2017, 8:10 PM

EP01 added a child revision: D1507: Update python-pytest to 3.3.1.Nov 30 2017, 8:20 PM

Fixed typo in component field.

Tested with pytest.

And what about its actual reverse dependencies like qutebrowser? Also given how small the changeset is, it wouldn't hurt to at least have a summarized changelog and link to the full one.

This revision now requires changes to proceed.Dec 4 2017, 10:21 PM