Page MenuHomeSolus

Update libnss to 3.34.1 & convert to ypkg
ClosedPublic

Authored by kyrios123 on Nov 30 2017, 2:18 PM.
Tags
None
Referenced Files
F10986038: D1499.diff
Sun, Jul 23, 11:39 PM
F10917876: D1499.id.diff
Jul 8 2023, 7:25 PM
F10789217: D1499.id3974.diff
May 26 2023, 6:47 PM
F10789200: D1499.id4032.diff
May 26 2023, 6:44 PM
F10789141: D1499.id3697.diff
May 26 2023, 6:35 PM
F10789137: D1499.diff
May 26 2023, 6:34 PM
F10766876: D1499.id3697.diff
May 19 2023, 8:55 PM
F10758765: D1499.id4032.diff
May 17 2023, 5:44 PM
Subscribers

Details

Summary

Release notes available here

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Successfully build suricata & volume_key against this version

Diff Detail

Repository
R1797 libnss
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Since I accidentally duplicated your work, I have some thoughts, doesn't mean you should implement them per say.

Do we need the static files for anything?
You could install the man pages for the corresponding binaries installed, they are found in nss/doc/nroff
for loops could be replaced with a single install line e.g. install -Dt $installdir%libdir% -m00644 dist/Linux*/lib/*.chk
From reading the COPYING file GPL-2.0 and LGPL-2.1 should be added to licences

Since I accidentally duplicated your work, I have some thoughts, doesn't mean you should implement them per say.

Do we need the static files for anything?
You could install the man pages for the corresponding binaries installed, they are found in nss/doc/nroff
for loops could be replaced with a single install line e.g. install -Dt $installdir%libdir% -m00644 dist/Linux*/lib/*.chk
From reading the COPYING file GPL-2.0 and LGPL-2.1 should be added to licences

Good point for the licenses. I saw it was released under MPL-2.0 but I didn't check further.

Regarding the package, I don't know why static libraries are shipped. I know that @ikey prefers that I split the work in multiple phases (i.e: convert the package without changing it, then make the modifications in a next update) so it's easier to tackle eventual issues and it doesn't remain in the queue during months (like the conversion/update/modifications I made all together for the cups package for example).
The only "change" I made to the package during the conversion was using %libdir% so libs are now in /usr/lib64 i.s.o. /usr/lib.

This of course, doesn't apply for you as you're more skilled/experienced than I am.

I never add man pages/docs for the packages that are in system.base/system.devel unless there is a request for it. But if you do so, you might consider adding -docs pattern (depending on the size) to prevent the base image from growing unnecessarily.

Fix licenses.
Poke @ikey for the other suggested changes.

LGTM - we can do follow up commits to clean it up. For complex conversions I prefer staged.

This revision is now accepted and ready to land.Dec 16 2017, 5:40 PM
This revision was automatically updated to reflect the committed changes.

SeemsGood, all of what @kyrios123 said seems sensible