Page MenuHomeSolus

Update to 4.5.1
AbandonedPublic

Authored by theSoenke on Nov 26 2017, 6:53 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary
Test Plan

Run gradle --version
Build test application

Diff Detail

Repository
R1050 gradle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
theSoenke created this revision.Nov 26 2017, 6:53 PM

Any chance you could update this to version 4.4.1? Wish this would get merged already :(

I understand that Gradle is updated very frequently and thus it's cumbersome to keep up with it. Plus, most Java IDEs support the wrapper.

But Gradle >4 is needed for updating https://dev.solus-project.com/source/jabref/ to version 4.1.

theSoenke updated this revision to Diff 5510.Feb 15 2018, 10:06 PM

Update to latest version 4.5.1
Remove desktop file for deprecated GUI

theSoenke retitled this revision from Update to 4.3.1 to Update to 4.5.1.Feb 15 2018, 10:06 PM

Updated it to the latest version. Maybe @JoshStrobl or @DataDrake can have a look?

DataDrake requested changes to this revision.Feb 15 2018, 10:59 PM

I need this tested against things that use gradle to build. Most importantly OpenJFX.

package.yml
23

The correct permissions for a directory are 00755 and automatically set.

This revision now requires changes to proceed.Feb 15 2018, 10:59 PM
theSoenke updated this revision to Diff 5532.Feb 17 2018, 12:29 PM
theSoenke edited edge metadata.

Set directory permissions correctly

And the OpenJFX rebuild?

theSoenke marked an inline comment as done.Feb 25 2018, 12:09 PM

@DataDrake I just tested it and unfortunately it fails. Actually only Gradle 1.8 seems to be officially supported for OpenJFX at this point

Unsupported gradle version 4.5.1 in use.
Only version 1.8 is supported. Use this version at your own risk

And the error:

> Task :graphics:generateDecoraShaders FAILED
Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/scenario/effect/Blend$Mode
        at CompileBlend.main(CompileBlend.java:47)
Caused by: java.lang.ClassNotFoundException: com.sun.scenario.effect.Blend$Mode
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 1 more

Maybe it is possible to backport this OpenJFX 10 patch http://hg.openjdk.java.net/openjfx/10-dev/rt/rev/0c458c14b6b9

We might have to consider packaging an older gradle for OpenJFX. Let me talk it over with @ikey and get back to you.

@DataDrake I just tested it and unfortunately it fails. Actually only Gradle 1.8 seems to be officially supported for OpenJFX at this point

Unsupported gradle version 4.5.1 in use.
Only version 1.8 is supported. Use this version at your own risk

Maybe it is possible to backport this OpenJFX 10 patch http://hg.openjdk.java.net/openjfx/10-dev/rt/rev/0c458c14b6b9

According to: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Gradle

Gradle is the primary build tool for building OpenJFX. We currently use Gradle 4.3 for jfx-dev (IMPORTANT: Only this version is regularly tested).

Where does it say Gradle 1.8 ?

Although I admit I did not test it myself.

DataDrake added a comment.EditedFeb 26 2018, 11:20 AM

@goek-han during the build itself

Edit: and 4.3 applies to newer version of OpenJFX, not version 8.