Update nheko to add runtime dependency
AbandonedPublic
Actions

Authored by nazar on Sat, Aug 5, 9:03 PM.

Details

Reviewers

TClark77
ReillyBrogan

Group Reviewers

Triage Team

Maniphest Tasks

T10614: qt5-graphicaleffects rundep is missing for nheko

Summary

adding rundep bc. on budgie nheko would display blank
screen unless qt5-graphicaleffects was manually installed

resolves T10614

Test Plan

join solus channels; say hello;

Diff Detail

Repository

R5651 nheko

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5374
Build 5374: arc lint + arc unit

Event Timeline

nazar created this revision.Sat, Aug 5, 9:03 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptSat, Aug 5, 9:03 PM

nazar requested review of this revision.Sat, Aug 5, 9:03 PM

Harbormaster completed remote builds in B5374: Diff 34893.Sat, Aug 5, 9:03 PM

Thanks for contributing this patch. Please update the task summary and the commit message to be more in line with our standards
https://github.com/solus-project/tooling-central/blob/master/README.rst#using-git

The task name should be "Update nheko to add runtime dependency"
Update the commit message to explain exactly what's being done and the reasoning (per the link above)
Add "resolves T10614" to the commit message.

The patch itself looks good.

This revision now requires changes to proceed.Sat, Aug 5, 9:11 PM

TClark77 added a reviewer: ReillyBrogan.Sat, Aug 5, 9:11 PM

Update nheko to add runtime dependency

Harbormaster completed remote builds in B5375: Diff 34895.Sat, Aug 5, 9:23 PM

nazar retitled this revision from resolves T10614 to Update nheko to add runtime dependency.Sat, Aug 5, 9:26 PM

nazar edited the summary of this revision. (Show Details)

nazar added a task: T10614: qt5-graphicaleffects rundep is missing for nheko.

Thanks for updating the task name and adding the link. My apologies, I missed one other thing.

The summary of the commit should be the same as the summary of this task
Please amend your commit with this. I'll let Reilly approve the commit since he's the maintainer.

This revision now requires changes to proceed.Sat, Aug 5, 9:32 PM