Update protonmail-bridge to v3.3.2
Needs ReviewPublic
Actions

Authored by FriesischScott on Thu, Jul 27, 7:33 PM.

Details

Reviewers

EbonJaeger

Group Reviewers

Triage Team

Summary

The build system changed a lot compared to the last update I did and I had to patch a number of things to make it work. Since the last release one of the binaries was split into bridge and bridge-gui which I included as proton-bridge and proton-bridge-gui. The launcher application remains as protonmail-bridge.

The new build uses vcpkg and I included port overlays for the dependencies to fall back on the system libaries. Because vcpkg is expected as a submodule I had to switch the build to the git tag.

Summarized changelog:

3.3.0
- Added new notifications to help users to configure and troubleshoot their email clients
3.2.0
- Enhanced the integration with the operating system by replacing status windows with native tray icon context menu
3.1.2
- Support for Protons Schedles send feature
- Synchronization indicatior in the GUI
3.0.20
- Fixed a bug that could cuase email states to come out of sync with the web application
3.0.17
- Significant rewrite of bridge and update to Qt6
- Improved sending and synchronization performance
- Added subfolder support

Full changelog: https://proton.me/download/bridge/stable_releases.html

Test Plan

Synced and sent mail through Thunderbird.

Diff Detail

Repository

R5138 protonmail-bridge

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5385
Build 5385: arc lint + arc unit

Event Timeline

FriesischScott created this revision.Thu, Jul 27, 7:33 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptThu, Jul 27, 7:33 PM

FriesischScott requested review of this revision.Thu, Jul 27, 7:33 PM

Harbormaster completed remote builds in B5338: Diff 34837.Thu, Jul 27, 7:33 PM

Fix version in git commit headline

Harbormaster completed remote builds in B5339: Diff 34838.Thu, Jul 27, 7:37 PM

FriesischScott retitled this revision from Update protonmail-bridge to v3.2.2 to Update protonmail-bridge to v3.3.2.Thu, Jul 27, 7:37 PM

Clean unused patches from package.yml

Harbormaster completed remote builds in B5342: Diff 34844.Fri, Jul 28, 2:19 PM

So generally we're still preferring to build apps with qt5 if possible if a particular app supports both qt5 and qt6. The reason for this is that qt5 apps tend to look better and more integrated on Plasma due to Plasma's Breeze theme not yet being ported to qt6. If this package only supports qt6 now that's fine, it may also apply it's own custom theme at which point it doesn't matter.

In D14293#245374, @ReillyBrogan wrote:

So generally we're still preferring to build apps with qt5 if possible if a particular app supports both qt5 and qt6. The reason for this is that qt5 apps tend to look better and more integrated on Plasma due to Plasma's Breeze theme not yet being ported to qt6. If this package only supports qt6 now that's fine, it may also apply it's own custom theme at which point it doesn't matter.

They only support qt6. But they don't use the system theme anyway.

cmake, ninja-build and Qt 6 are required to build the graphical user interface.

Just a couple things that I noticed.

package.yml
22	This should go above the icu-uc dependency because of alphabetical ordering.
27	We're trying to move to `%patch -p1 -i $pkgfiles/name-of-file.patch` for patching files. If you could do that here, that'd be great. :)