Page MenuHomeSolus
Differential D14280

drumstick: Update to 2.8.0
ClosedPublic
Actions

Authored by stalebrim on Mon, Jul 24, 12:00 AM.
Tags
None
Referenced Files
F11005570: D14280.id34809.diff
Tue, Aug 1, 8:00 AM
F11005569: D14280.id.diff
Tue, Aug 1, 8:00 AM
F11003085: D14280.diff
Mon, Jul 31, 10:56 AM
F11001406: D14280.id.diff
Sun, Jul 30, 4:27 AM
F11000939: D14280.id34809.diff
Sat, Jul 29, 6:40 PM
F11000023: D14280.diff
Sat, Jul 29, 12:51 AM
F10998906: D14280.diff
Fri, Jul 28, 6:05 AM
Subscribers
EbonJaeger

Details

Reviewers
EbonJaeger
Group Reviewers
Triage Team
Commits
R666:3373083da662: drumstick: Update to 2.8.0
Summary

Changelog available here
Depends on D14279.

Test Plan
  • Build VMPK
  • Check VMPK works

Diff Detail

Repository
R666 drumstick
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5386
Build 5386: arc lint + arc unit

Event Timeline

stalebrim created this revision.Mon, Jul 24, 12:00 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptMon, Jul 24, 12:00 AM
stalebrim requested review of this revision.Mon, Jul 24, 12:00 AM
Harbormaster completed remote builds in B5319: Diff 34809.Mon, Jul 24, 12:00 AM
stalebrim added a child revision: D14281: vmpk: Update to 0.8.9.Mon, Jul 24, 12:03 AM
EbonJaeger requested changes to this revision.Thu, Jul 27, 9:37 PM
EbonJaeger added a subscriber: EbonJaeger.
EbonJaeger added inline comments.
package.yml
13

The dependency is added, but the package isn't being built with DBus support. Is that intentional?

This revision now requires changes to proceed.Thu, Jul 27, 9:37 PM
stalebrim updated this revision to Diff 34908.Mon, Aug 7, 4:01 PM

Enable dbus and apply a patch for build

Harbormaster completed remote builds in B5382: Diff 34908.Mon, Aug 7, 4:01 PM
EbonJaeger requested changes to this revision.Mon, Aug 7, 6:13 PM
EbonJaeger added inline comments.
package.yml
24–25

We're trying to move to %patch -p1 -i $pkgfiles/name-of-file.patch for patching files. If you could do that here, that'd be great. :)

This revision now requires changes to proceed.Mon, Aug 7, 6:13 PM
stalebrim updated this revision to Diff 34912.Tue, Aug 8, 9:35 AM
stalebrim marked an inline comment as done.

Add homepage

Harbormaster completed remote builds in B5386: Diff 34912.Tue, Aug 8, 9:35 AM
stalebrim updated this revision to Diff 34913.Tue, Aug 8, 9:36 AM

Make the actual change that was requested

Harbormaster completed remote builds in B5387: Diff 34913.Tue, Aug 8, 9:36 AM
stalebrim retitled this revision from Update drumstick to 2.8.0 to drumstick: Update to 2.8.0.Tue, Aug 8, 11:38 AM
EbonJaeger accepted this revision.Tue, Aug 8, 2:10 PM

LGTM, thanks! :)

This revision is now accepted and ready to land.Tue, Aug 8, 2:10 PM
Closed by commit R666:3373083da662: drumstick: Update to 2.8.0 (authored by stalebrim, committed by EbonJaeger). · Explain WhyTue, Aug 8, 2:11 PM
This revision was automatically updated to reflect the committed changes.
EbonJaeger added a commit: R666:3373083da662: drumstick: Update to 2.8.0.

Revision Contents
Changeset List

Diff 34912

View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

abi_used_symbols

Loading...
View Options

files/0001-Fixed-GH-ticket-13-build-errors-in-drumstick-2.8.0.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.