Page MenuHomeSolus

update ncdu to 2.2.2
ClosedPublic

Authored by nazar on Jun 10 2023, 9:03 AM.
Tags
None
Referenced Files
F11017945: D14194.diff
Sun, Aug 6, 8:04 AM
F11004480: D14194.diff
Tue, Aug 1, 1:48 AM
F10960259: D14194.diff
Tue, Jul 18, 10:36 AM
F10880126: D14194.id.diff
Jun 22 2023, 2:43 PM
F10873916: D14194.id34622.diff
Jun 19 2023, 8:08 PM
F10873198: D14194.diff
Jun 19 2023, 9:23 AM
F10872977: D14194.id34621.diff
Jun 19 2023, 6:11 AM
F10865202: D14194.id34622.diff
Jun 17 2023, 10:37 AM

Details

Summary

Changelog:

Test Plan

run and check sizes are shown correct

Diff Detail

Repository
R2140 ncdu
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nazar requested review of this revision.Jun 10 2023, 9:03 AM

I don't know why, this package fails on my machine.

+ make -j4
zig build -Drelease-fast
make: *** [Makefile:15: release] Illegal instruction (core dumped)
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-buildYZfqts']' returned non-zero exit status 2
[Build] build failed for ncdu
 🕱  Failed to build packages

Yeah, same issue on my machine.

@algent do you do =make local= with new zig eopkg?
@Staudey updated ncdu requires recent zig build; did you use 0.10.1 or 0.9.1?
Here's my finding

  • new zig eopkg in unstable is 19M (fails at ncdu build)
  • locally build zig eopkg is 24M (compiles ncdu all right)

Also hashes are different obviously.

  • 2b10974602a2b30a5573203d2fcfb444455c2d79e1c3ee01fe4ba9b1fd39038e lib/solbuild/packages/zig-0.10.1-4-1-x86_64.eopkg
  • 1205b14b99cae0e2faf457399fe415111ab849d26cfc1d2399b109e3a80c9a29 lib/solbuild/local/zig-0.10.1-4-1-x86_64.eopkg

It does look like there are some bits missing and the updated zig compiler package is borked (landed into unstable too soon).

@algent do you do =make local= with new zig eopkg?

It is not building with new zig.

It must be this bit -DZIG_STATIC_LLVM=ON

@algent it should work again, see D14197

silke requested changes to this revision.EditedJun 12 2023, 6:02 PM
silke added a subscriber: silke.

This now has the same issue as zig 😢:

$ ncdu
fish: Job 1, 'ncdu' terminated by signal SIGILL (Illegal instruction)

Should be fixed by using the following to build instead of %make (which should be fine according to the Makefile): Edit: see comment below.

This revision now requires changes to proceed.Jun 12 2023, 6:02 PM

After some discussion on Matrix, adding the following to package.yml (before build) is probably cleaner (and keeps %make intact):

environment: |
    # Ensure ncdu is built for generic x86_64 targets
    export ZIG_FLAGS="-Drelease-fast -Dcpu=baseline"

Ensure ncdu is built for generic x86_64 targets

That does the trick. LGTM, thanks!

This revision is now accepted and ready to land.Jun 12 2023, 8:31 PM
This revision was automatically updated to reflect the committed changes.