Paths

Table of Contentst

Differential D14178

Update minikube to 1.30.1
ClosedPublic
Actions

Authored by chax on Jun 6 2023, 3:01 AM.

Tags

None

Referenced Files

	F11018937: D14178.diff
	Sun, Aug 6, 4:02 PM

	F11004782: D14178.diff
	Tue, Aug 1, 3:26 AM

	F11001338: D14178.diff
	Sun, Jul 30, 2:50 AM

	F11000979: D14178.id34548.diff
	Sat, Jul 29, 7:42 PM

	F10960285: D14178.diff
	Tue, Jul 18, 10:45 AM

	F10925010: D14178.diff
	Mon, Jul 10, 5:49 AM

	F10866135: D14178.id34605.diff
	Jun 17 2023, 2:06 PM

	F10866131: D14178.id34548.diff
	Jun 17 2023, 2:05 PM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R2075:ef9f4345f8e9: Update minikube to 1.30.1

Summary

Update minikube to 1.30.1
Changelog can be found here

Test Plan

Run few minikube commands:

minikube start
list pods using kubectl: kubectl get pods --all-namespaces
minikube dashboard
minikube stop
minikube delete

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chax created this revision.Jun 6 2023, 3:01 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 6 2023, 3:01 AM

chax requested review of this revision.Jun 6 2023, 3:01 AM

Harbormaster completed remote builds in B5157: Diff 34548.Jun 6 2023, 3:01 AM

Hmm, so this fails in the check step for me. Might be particular to my network though.

--- FAIL: TestFreeSubnet (0.00s)
    --- FAIL: TestFreeSubnet/NoRetriesSuccess (0.00s)
        network_test.go:34: no free private network subnets found with given parameters (start: "192.168.0.0", step: 0, tries: 1)
FAIL
	k8s.io/minikube/pkg/network	coverage: 81.1% of statements
FAIL	k8s.io/minikube/pkg/network	0.005s
ok  	k8s.io/minikube/pkg/util	0.437s	coverage: 77.4% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 22.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
make: *** [Makefile:400: test] Error 3

Going to see if it works on the build server anyway.

Staudey accepted this revision.Jun 11 2023, 12:50 PM

This revision is now accepted and ready to land.Jun 11 2023, 12:50 PM

Closed by commit R2075:ef9f4345f8e9: Update minikube to 1.30.1 (authored by chax, committed by Staudey). · Explain WhyJun 11 2023, 12:51 PM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R2075:ef9f4345f8e9: Update minikube to 1.30.1.

Yeah, worked fine on the server. Nice

I think it did fail for me locally also, first time, but second time it passed. Might be flaky test.

Revision Contents
Changeset List

Path

Size

abi_used_symbols

2 lines

6 lines

pspec_x86_64.xml

6 lines

Diff 34605

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...