Details

Reviewers

joebonrichie
silke

Group Reviewers

Triage Team

Commits

R3311:0337a587fcbe: Update yubico-authenticator to 6.2.0 and build from source

Summary

Depends on D14201, D14202.

Changelog available here.
Now building from source using Flutter. We fetch the Flutter SDK as a source since including the Flutter SDK in our repository still needs a bit of work.
Install the authenticator-helper Python executable and manage its runtime dependencies by ourselves instead of letting pyinstaller bundle all of its dependencies.

Test Plan

I don't have a Yubikey, so I can only make sure it runs...

Diff Detail

Repository

R3311 yubico-authenticator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

GZGavinZhao created this revision.Jun 5 2023, 5:41 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJun 5 2023, 5:41 PM

GZGavinZhao requested review of this revision.Jun 5 2023, 5:41 PM

Harbormaster completed remote builds in B5147: Diff 34537.Jun 5 2023, 5:41 PM

GZGavinZhao edited the test plan for this revision. (Show Details)Jun 5 2023, 5:41 PM

GZGavinZhao edited the test plan for this revision. (Show Details)

GZGavinZhao added a subscriber: Tracing.

GZGavinZhao removed a subscriber: Tracing.

Nice job! This should be able to be built with our system python-poetry package now.

I also wonder if it's possible to nuke the bundled libs now? Basically, everything in the helper dir apart from authenticator-helper and possibly base_library.zip by the looks of things. If the unbundling is too much of a headache, we can leave it for now.

joebonrichie requested changes to this revision.Jun 5 2023, 5:56 PM

This revision now requires changes to proceed.Jun 5 2023, 5:56 PM

joebonrichie added inline comments.Jun 5 2023, 5:59 PM

pspec_x86_64.xml
88–89	Probably don't want to include this

Sorry, I've been a bit busy this week. I rebuilt against our own python-poetry and I've been trying to remove the bundled libraries in helper. Currently, I am able to remove all of them except zxing-cpp, and I'll try to work it out in the next few days.

Build with our own python-poetry.
Strip out all the bundled libs in the /usr/share/yubioath-desktop/helper directory and manage the runtime dependency of the authenticator-helper Python script by ourselves.