Page MenuHomeSolus

initial version of nfft
ClosedPublic

Authored by hashhsah on Nov 19 2017, 3:56 PM.

Details

Reviewers
joebonrichie
Group Reviewers
Triage Team
Maniphest Tasks
T4426: nfft
Commits
R3839:5929d2bebd3d: initial version of nfft
Summary

Initial version of nfft
Fixes T4426.

Signed-off-by: Shen Chen <shenchen@cogenda.com>

Test Plan
  • pip install nfft-cffi
  • # extract tests/test_nfft.py from nfft-cffi tarball
  • nosetests-2.7 test_nfft.py
  • # all tests should pass

Diff Detail

Repository
R3839 nfft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hashhsah created this revision.Nov 19 2017, 3:56 PM
joebonrichie requested changes to this revision.Nov 19 2017, 4:42 PM
joebonrichie added a subscriber: joebonrichie.
joebonrichie added inline comments.
package.yml
11

Should probably be programming.library

13

Should use a pkgconfig for this instead. eopkg info fftw-devel

15

So --prefix=/usr and --libdir=%libdir% shouldn't be necessary as they are already defined in our macros.
https://github.com/solus-project/ypkg/blob/master/ypkg2/rc.yml#L127

This revision now requires changes to proceed.Nov 19 2017, 4:42 PM

You can test this against python-nfft-cffi we don't have it the repos so you can install it via pip or package it yourself locally.

hashhsah updated this revision to Diff 3510.Nov 19 2017, 5:53 PM
hashhsah edited edge metadata.

revise patch according to joebonrichie's review comments.

Test Plan:

  • pip install nfft-cffi
  • # extract tests/test_nfft.py from nfft-cffi tarball
  • nosetests-2.7 test_nfft.py
  • # all tests should pass

Your test plan should be part of the commit message under 'Test Plan'.

package.yml
15

Should have mentioned this before but --enable-shared & --enable-openmp are also not required, they are enabled by default.

joebonrichie requested changes to this revision.Nov 19 2017, 6:19 PM
This revision now requires changes to proceed.Nov 19 2017, 6:19 PM
hashhsah updated this revision to Diff 3512.Nov 19 2017, 6:48 PM
hashhsah edited edge metadata.

initial version of nfft

Summary:
Initial version of nfft
Fixes T4426.

Test Plan:

  • pip install nfft-cffi
  • # extract tests/test_nfft.py from nfft-cffi tarball
  • nosetests-2.7 test_nfft.py
  • # all tests should pass
hashhsah updated this revision to Diff 3513.Nov 19 2017, 6:56 PM
hashhsah edited the test plan for this revision. (Show Details)

revise again per comments

hashhsah updated this revision to Diff 3514.Nov 19 2017, 7:23 PM

remove --enable-shared/--enable-openmp, which are turned-on by default

joebonrichie accepted this revision.Nov 19 2017, 7:42 PM
This revision is now accepted and ready to land.Nov 19 2017, 7:42 PM
This revision was automatically updated to reflect the committed changes.