Page MenuHomeSolus

mesalib: backport a patch for VAAPI crash
ClosedPublic

Authored by aleksvor on May 20 2023, 8:34 PM.
Tags
None
Referenced Files
F11006898: D14137.diff
Tue, Aug 1, 5:37 PM
F10932336: D14137.diff
Wed, Jul 12, 1:19 AM
F10892313: D14137.id34462.diff
Jun 29 2023, 9:55 PM
F10889555: D14137.id34461.diff
Jun 28 2023, 12:19 AM
F10887551: D14137.diff
Jun 26 2023, 1:54 PM
F10867390: D14137.id34462.diff
Jun 17 2023, 7:59 PM
F10867387: D14137.id34461.diff
Jun 17 2023, 7:59 PM
F10867385: D14137.id.diff
Jun 17 2023, 7:59 PM
Subscribers

Details

Summary

This diff contains a patch that fixes a crash that I found when using mpv. The crash occurs with following clauses and steps:

  1. Use AMD GPU.
  2. Use mpv with gpu-next video output (probably current gpu output is affected too, haven't tried it) and VAAPI hwdec.
  3. Watch a high-bitrate video or livestream and try to seek to the timestamp that wasn't cached yet.

You'll likely get a segfault which traces into radeonsi_drv_video.so. This patch adds the necessary nullptr check to prevent this segfault.

Test Plan

Watched a video that I wasn't able to reliably seek previosly when using VAAPI. Now I can seek to any timestamp, and while I can get a few dropped frames, it doesn't crash anymore.

Diff Detail

Repository
R2066 mesalib
Lint
Lint Not Applicable
Unit
Tests Not Applicable