Rebuild shellcheck with static linking
Needs ReviewPublic
Actions

Authored by liontiger23 on Wed, May 3, 2:53 AM.

Details

Reviewers

None

Group Reviewers

Triage Team

Maniphest Tasks

T10510: Update shellcheck to 0.9.0
T10289: Update ghc (and the Haskell stack) to 9

Summary

Rebuild shellcheck with static linking to simplify upgrading of Haskell stack.

Eliminates the last dependency on

haskell-Diff
haskell-regex-tdfa

So they can be deprecated now.

Test Plan

Verified output on some scripts:

$ shellcheck /usr/bin/gettext.sh

In /usr/bin/gettext.sh line 20:
if test "X`(echo '\t') 2>/dev/null`" = 'X\t'; then
          ^-----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
                 ^--^ SC2028 (info): echo may not expand escape sequences. Use printf.

Did you mean:
if test "X$((echo '\t') 2>/dev/null)" = 'X\t'; then

In /usr/bin/gettext.sh line 23:
  if test "X`(printf '%s\n' '\t') 2>/dev/null`" = 'X\t'; then
            ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  if test "X$((printf '%s\n' '\t') 2>/dev/null)" = 'X\t'; then

In /usr/bin/gettext.sh line 31:
    echo='echo_func'
    ^--^ SC2034 (warning): echo appears unused. Verify use (or export if used externally).

In /usr/bin/gettext.sh line 88:
  gettext "$1" | (export PATH `envsubst --variables "$1"`; envsubst "$1")
                              ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting.
                              ^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  gettext "$1" | (export PATH $(envsubst --variables "$1"); envsubst "$1")

In /usr/bin/gettext.sh line 95:
  ngettext "$1" "$2" "$3" | (export PATH `envsubst --variables "$1 $2"`; envsubst "$1 $2")
                                         ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                         ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  ngettext "$1" "$2" "$3" | (export PATH $(envsubst --variables "$1 $2"); envsubst "$1 $2")

In /usr/bin/gettext.sh line 102:
  gettext --context="$1" "$2" | (export PATH `envsubst --variables "$2"`; envsubst "$2")
                                             ^-------------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                             ^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  gettext --context="$1" "$2" | (export PATH $(envsubst --variables "$2"); envsubst "$2")

In /usr/bin/gettext.sh line 109:
  ngettext --context="$1" "$2" "$3" "$4" | (export PATH `envsubst --variables "$2 $3"`; envsubst "$2 $3")
                                                        ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                                        ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
  ngettext --context="$1" "$2" "$3" "$4" | (export PATH $(envsubst --variables "$2 $3"); envsubst "$2 $3")

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- echo appears unused. Verify use (...
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2028 -- echo may not expand escape sequen...