closes T10515
Details
Details
- Reviewers
kostadinsh - Group Reviewers
Triage Team - Maniphest Tasks
- T10515: package flatpak-kcm
- Commits
- R5705:93aa3509017e: Initial inclusion of flatpak-kcm
Ran an application, changed permissions and confirmed that the changes were applied.
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 5039 Build 5039: arc lint + arc unit
Event Timeline
Comment Actions
Some minor notes, I'll leave the rest to the KDE guys
| files/flatpak-discover.svg | ||
|---|---|---|
| 9 | Is this file also licensed under GPL-2.0-or-later? | |
| package.yml | ||
| 21 | Thanks for sorting the dependencies, but unfortunately we sort pkgconfig() before regular dependencies, and also A-Z before a-z (i.e. uppercase before lowercase, so Qt before flatpak | |
| 23 | It seems to pick up the flatpak dependency automatically during the build, so you don't need this rundeps section [Dependency] /usr/lib64/qt5/plugins/plasma/kcms/systemsettings/kcm_flatpak.so adds dependency on libflatpak.so.0 from flatpak | |
Comment Actions
Doing some digging I found the source for the .svg file in kde discover
https://invent.kde.org/plasma/discover/-/blob/master/libdiscover/backends/FlatpakBackend/sc-apps-flatpak-discover.svg
which includes these licenses all of which allow redistribution
https://invent.kde.org/plasma/discover/-/tree/master/LICENSES
Comment Actions
Can you update to 5.27.5 and remove the maintainers.md file as whoever updates the plasma stack will need to update this alongside it regardless. Otherwise LGTM, thanks for packaging this up!