Page MenuHomeSolus

Initial inclusion of flatpak-kcm

Authored by joebonrichie on May 2 2023, 9:33 PM.
Referenced Files
F10794624: D14085.diff
Sat, May 27, 4:49 PM
Mon, May 22, 2:04 AM
F10761374: D14085.diff
Thu, May 18, 8:49 AM
F10738099: D14085.diff
Sat, May 13, 9:20 AM
F10727113: D14085.id34339.diff
Tue, May 9, 5:51 PM
F10726852: D14085.id34338.diff
Tue, May 9, 2:40 PM
F10726533: D14085.diff
Tue, May 9, 8:08 AM
F10722145: D14085.diff
Sat, May 6, 5:45 PM
"Doubloon" token, awarded by davidjharder.



closes T10515

Test Plan

Ran an application, changed permissions and confirmed that the changes were applied.

Diff Detail

R5705 flatpak-kcm
Lint Not Applicable
Tests Not Applicable

Event Timeline

Fix component, sort dependencies in alphabetical order

Some minor notes, I'll leave the rest to the KDE guys


Is this file also licensed under GPL-2.0-or-later?


Thanks for sorting the dependencies, but unfortunately we sort pkgconfig() before regular dependencies, and also A-Z before a-z (i.e. uppercase before lowercase, so Qt before flatpak


It seems to pick up the flatpak dependency automatically during the build, so you don't need this rundeps section

[Dependency] /usr/lib64/qt5/plugins/plasma/kcms/systemsettings/ adds dependency on from flatpak

Fix all notes from Staudey's review, except for the license for the icon

joebonrichie requested changes to this revision.EditedWed, May 10, 7:19 PM
joebonrichie added a subscriber: joebonrichie.

Can you update to 5.27.5 and remove the file as whoever updates the plasma stack will need to update this alongside it regardless. Otherwise LGTM, thanks for packaging this up!

This revision now requires changes to proceed.Wed, May 10, 7:19 PM
joebonrichie edited reviewers, added: kostadinsh; removed: joebonrichie.

Commandeering just to get this in

This revision was not accepted when it landed; it landed in state Needs Review.Sat, May 13, 10:20 AM
This revision was automatically updated to reflect the committed changes.