Paths

Table of Contentst

Differential D14076

Update rocm-compilersupport to 5.3.3
ClosedPublic
Actions

Authored by Jacek on May 1 2023, 10:02 PM.

Tags

None

Referenced Files

	F10794604: D14076.diff
	Sat, May 27, 4:46 PM

	F10777854: D14076.id.diff
	Wed, May 24, 1:51 AM

	F10754278: D14076.diff
	Tue, May 16, 8:19 PM

	F10721613: D14076.id34322.diff
	Sat, May 6, 1:08 PM

	F10721612: D14076.id.diff
	Sat, May 6, 1:08 PM

	F10715478: D14076.id34322.diff
	Thu, May 4, 6:41 AM

	F10715477: D14076.id.diff
	Thu, May 4, 6:40 AM

	F10714003: D14076.diff
	Wed, May 3, 2:06 PM

View All 9 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R5563:ab4b3f15156e: Update rocm-compilersupport to 5.3.3

Summary

Depends on D14075
Update for ROCm stack update
Detailed changelog here

Test Plan

rocm-hip and rocm-opencl work

Diff Detail

Repository

R5563 rocm-compilersupport

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Jacek created this revision.May 1 2023, 10:02 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMay 1 2023, 10:02 PM

Jacek requested review of this revision.May 1 2023, 10:02 PM

Harbormaster completed remote builds in B5020: Diff 34322.May 1 2023, 10:02 PM

Jacek added a child revision: D14077: Update rocm-runtime to 5.3.3.May 1 2023, 10:05 PM

Jacek added a child revision: D14079: Update rocminfo to 5.3.3.May 1 2023, 10:13 PM

When I build this it creates <Path fileType="header">/usr/include/amd_comgr.h</Path>
in addition to the <Path fileType="header">/usr/include/amd_comgr/amd_comgr.h</Path> shown here

btw that's quite a lot of sed action. Wouldn't it be a bit cleaner to use patches instead? Not that I would want to block this diff solely based on that.

Remove sed commands leftover from package of 5.1.3 and 5.2.3, switch off reorg backward compatibility to remove redundant header file, add patch for Blender

Harbormaster completed remote builds in B5041: Diff 34350.Wed, May 3, 12:26 PM

Bring back some necessary sed commands as they are needed to fix tests, replace some with a patch from Gentoo

Harbormaster completed remote builds in B5042: Diff 34351.Wed, May 3, 12:57 PM

LGTM, thanks!

This revision is now accepted and ready to land.Wed, May 3, 6:36 PM

Closed by commit R5563:ab4b3f15156e: Update rocm-compilersupport to 5.3.3 (authored by Jacek, committed by Staudey). · Explain WhyWed, May 3, 6:36 PM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R5563:ab4b3f15156e: Update rocm-compilersupport to 5.3.3.

Revision Contents
Changeset List

Path

Size

3 lines

2 lines

abi_used_symbols

3678 lines

files/

0001-COMGR-changes-needed-for-https-github.com-llvm-llvm-.patch

0001-Detect-if-clang-is-static-or-shared.patch

0001-Fix-cmake-file-location.patch

0001-Remove--h-option.patch

38 lines

remove-gnu-compression-type.patch

31 lines

rocm-comgr-5.3.3-fix-tests.patch

17 lines

6 lines

27 lines

pspec_x86_64.xml

10 lines

Diff 34356

MAINTAINERS.md

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

files/0001-COMGR-changes-needed-for-https-github.com-llvm-llvm-.patch

Loading...

files/0001-Detect-if-clang-is-static-or-shared.patch

Loading...

files/0001-Fix-cmake-file-location.patch

Loading...

files/0001-Remove--h-option.patch

Loading...

files/remove-gnu-compression-type.patch

Loading...

files/rocm-comgr-5.3.3-fix-tests.patch

Loading...

files/series

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...