Page MenuHomeSolus
Differential D14031

Update deadbeef to 1.9.5, fixed 'Help' menu bug
ClosedPublic
Actions

Authored by wwsmiff on Apr 25 2023, 9:15 AM.
Tags
None
Referenced Files
F11024576: D14031.diff
Tue, Aug 8, 10:30 PM
F11005081: D14031.diff
Tue, Aug 1, 5:26 AM
F10901029: D14031.diff
Jul 4 2023, 4:11 PM
F10866840: D14031.diff
Jun 17 2023, 5:38 PM
F10807980: D14031.id34196.diff
May 30 2023, 6:45 AM
F10807579: D14031.id34197.diff
May 30 2023, 5:29 AM
F10807420: D14031.id34232.diff
May 30 2023, 4:51 AM
F10807156: D14031.id34230.diff
May 30 2023, 3:55 AM
View All 31 Files
Subscribers
algent
Staudey
Tokens
"Party Time" token, awarded by davidjharder.

Details

Reviewers
algent
Group Reviewers
Triage Team
Commits
R607:31da2e032d7e: Update deadbeef to 1.9.5, fixed 'Help' menu bug
Summary

Changelog:

  • Fixed: GME chiptune voice muting was affecting converter / replaygain scanner
  • Fixed: SID chiptune voice muting was affecting converter / replaygain scanner
  • Fixed: SID stereo was not working the way it was intended
  • Fixed: Wave format conversion regressions, which could lead to wrong channels mapping
  • Fixed: Converter race condition bug when checking whether a directory exists
  • Fixed: Album art fetching for tracks with multiple artists
  • Fixed: GTK warning when opening track properties
  • Fixed: Prompting before deleting playlist via middle mouse button
  • Fixed: Album art left/right/center alignment in GTKUI
  • Fixed: Removed embedded album art size limit for ID3v2 tags
  • Fixed: Deadlock when trying to delete files from disk
  • Fixed: Mute functionality for output plugins with their own volume control
  • Fixed: Switching to previous/next track after the current track is removed
  • Fixed: Incorrect playlist affected by hotkeys
  • Fixed: Unsynchronized ID3v2 tag loading
  • Fixed: Spectrum analyzer buffer overflow
  • Fixed: Deadlock when removing multiple selected tracks while one of them is playing
  • Added: Pipewire output plugin
  • Added: LibRetro resampling plugin
  • Added: Chiptune voice muting in DUMB plugin
  • Added: Improved drawing of spectrum analyzer
  • Added: $itematindex(index,value) function to title formatting, get value by index from multivalue fields
Test Plan

Played,Paused,Stopped songs, Created new playlists, Added files, Tested all menu sections, Tested important settings, Tested volume control, Tested keybindings

Diff Detail

Repository
R607 deadbeef
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4952
Build 4952: arc lint + arc unit

Event Timeline

wwsmiff created this revision.Apr 25 2023, 9:15 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptApr 25 2023, 9:15 AM
wwsmiff requested review of this revision.Apr 25 2023, 9:15 AM
Harbormaster completed remote builds in B4951: Diff 34196.Apr 25 2023, 9:15 AM
wwsmiff updated this revision to Diff 34197.Apr 25 2023, 9:20 AM
wwsmiff edited the summary of this revision. (Show Details)

Changed changelog

Harbormaster completed remote builds in B4952: Diff 34197.Apr 25 2023, 9:20 AM
davidjharder awarded a token.Apr 25 2023, 11:37 AM
algent edited the summary of this revision. (Show Details)Apr 25 2023, 3:47 PM
algent requested changes to this revision.Apr 25 2023, 10:26 PM
algent added a subscriber: algent.

Hey @wwsmiff. I get changes in other files too like:

modified:   abi_libs
modified:   abi_symbols
modified:   abi_used_symbols

This means that you didn't submit these files in this diff. You need to include them too. You have to include everything except the .eopkg files.

This revision now requires changes to proceed.Apr 25 2023, 10:26 PM
Staudey added a subscriber: Staudey.Apr 25 2023, 11:08 PM

Alternatively it could also mean you're still using the old solbuild images. Make sure to re-initialize solbuild if you have an old installation from before the outage (or manually downloaded the solbuild images before they were available from within solbuild itself)

sudo solbuild dc -i
sudo solbuild init
wwsmiff added a comment.Apr 26 2023, 12:43 AM

Oh, I see, well I ran

ypkg package.yml
make clean

and submitted it, but i think as Staudey suggests, I might not have the right version of solbuild, I'll update this.

wwsmiff updated this revision to Diff 34229.Apr 26 2023, 12:49 AM
  • Updated abi files
Harbormaster completed remote builds in B4964: Diff 34229.Apr 26 2023, 12:49 AM
wwsmiff updated this revision to Diff 34230.Apr 26 2023, 1:09 AM

Update deadbeef to 1.9.5, fixed 'Help' menu bug

Harbormaster completed remote builds in B4965: Diff 34230.Apr 26 2023, 1:09 AM
algent accepted this revision.Apr 26 2023, 3:40 AM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 26 2023, 3:40 AM
Closed by commit R607:31da2e032d7e: Update deadbeef to 1.9.5, fixed 'Help' menu bug (authored by wwsmiff, committed by algent). · Explain WhyApr 26 2023, 3:41 AM
This revision was automatically updated to reflect the committed changes.
algent added a commit: R607:31da2e032d7e: Update deadbeef to 1.9.5, fixed 'Help' menu bug.

Revision Contents
Changeset List

PathSize
8 lines
23 lines

Diff 34197

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.