Differential D1401

mysql-connector-cpp
AbandonedPublic
Actions

Authored by frbuceta on Nov 16 2017, 10:20 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Maniphest Tasks

T4281: mysql-connector-c++
T243: MySQL Workbench

Summary

Get connect mariadb with MySQL workbench

Test Plan

Tested in a c ++ test

https://dev.mysql.com/doc/connector-cpp/en/connector-cpp-examples-complete-example-1.html

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

frbuceta created this revision.Nov 16 2017, 10:20 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 16 2017, 10:20 PM

frbuceta added tasks: T243: MySQL Workbench, T4281: mysql-connector-c++.Nov 16 2017, 10:21 PM

frbuceta edited the summary of this revision. (Show Details)Nov 16 2017, 10:29 PM

You need to actually rebuild this.
You don't need to Markdown the differential link, Phab will automatically do that.
You didn't add a test plan, so how did you test this?

This revision now requires changes to proceed.Nov 18 2017, 7:03 PM

Update patch files

compilation satisfactory

This is not a valid test plan. Explain in the test plan how you tested this library.

This revision now requires changes to proceed.Nov 20 2017, 7:54 PM

Fix library

frbuceta edited the test plan for this revision. (Show Details)Nov 21 2017, 7:33 PM

JoshStrobl mentioned this in D936: MySQL C++ bindings for T4281. Dependency for MySQL Workbench, allowing completion of T243..Nov 25 2017, 4:39 PM

Tested in a c ++ test

Do you have any example code for the test plan?

JoshStrobl requested changes to this revision.Dec 4 2017, 9:43 PM

This revision now requires changes to proceed.Dec 4 2017, 9:43 PM

@frbuceta here is some example code to try so you can finish the diff

In D1401#25282, @tristan957 wrote:

@frbuceta here is some example code to try so you can finish the diff

In D1401#23876, @JoshStrobl wrote:

Tested in a c ++ test

Do you have any example code for the test plan?

I have not tried it but I think it works

frbuceta requested review of this revision.Dec 22 2017, 3:42 PM

frbuceta edited the test plan for this revision. (Show Details)

frbuceta edited edge metadata.

Please ensure you are using our generating a package.yml script, because I'm seeing a lot of inconsistent spacing here and you're using 8 spaces instead of 4.

This revision now requires changes to proceed.Dec 28 2017, 6:02 PM