Details

Reviewers

algent

Group Reviewers

Triage Team

Commits

R4728:73777de979ff: Update to 0.8.12

Summary

Changelog:

Signed-off-by: Joshua AE Lee <josh@10leej.com>

Test Plan

package should build and run successfully, tested all features and they seem to work perfectly run over ssh

Diff Detail

Repository

R4728 vorta

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

10leej created this revision.Apr 23 2023, 8:09 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptApr 23 2023, 8:09 AM

10leej requested review of this revision.Apr 23 2023, 8:09 AM

Harbormaster completed remote builds in B4911: Diff 34115.Apr 23 2023, 8:09 AM

Hey Joshua.

When you finish the changes, make sure to submit them with git commit --amend, to avoid creating a new diff.

package.yml
2	Release should be 22.
25	Minor thing. Please set `python-platformdirs` after `python-peewee`. This is required to alphabetise order of builddeps and rundeps.

This revision now requires changes to proceed.Apr 23 2023, 8:35 AM

Update to 0.8.12
alphabetized rundeps, release should be 23 I made a mistake in a git reset on the last commit

Harbormaster completed remote builds in B4916: Diff 34120.Apr 23 2023, 9:13 AM

this revision should set the pspec_x86_64.xml file

Harbormaster completed remote builds in B4917: Diff 34121.Apr 23 2023, 9:23 AM

Update to 0.8.12
rebasing form 0.8.9

Harbormaster completed remote builds in B4918: Diff 34122.Apr 23 2023, 9:32 AM

ok this is weird, I went to make my changes again trying to get the log to show I'm basing from 0.8.9 after I run git commit --amend it seems to automagically rebase me to 0.8.6 somehow during commit?

{F10691316}

{F10691318}

bash history (I cancelled the arc diff)
{F10691320}

In D14005#240157, @10leej wrote:

ok this is weird, I went to make my changes again trying to get the log to show I'm basing from 0.8.9 after I run git commit --amend it seems to automagically rebase me to 0.8.6 somehow during commit?

If you start fresh, then you don't have to run git commit --amend, but only git commit and then submit the diff with arc diff --update D14005.