Page MenuHomeSolus

Initial Commit of Numix Square Icon Theme Fixes T3676
ClosedPublic

Authored by RaspberryRye on May 18 2017, 8:10 PM.

Details

Summary

Inital Commit of Numix Square Icon Theme

Test Plan

Installed icon theme on personal system and all icons show like they are supposed to.

Diff Detail

Repository
R3461 numix-icon-theme-square
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

RaspberryRye created this revision.May 18 2017, 8:10 PM
JoshStrobl requested changes to this revision.May 18 2017, 9:09 PM
JoshStrobl added a subscriber: JoshStrobl.

You're chmoding folders that you never copied to the icons dir, and it looks like you meant to do a cp on those anyways. The only thing this eopkg is gonna have is an empty icons dir.

You also didn't add a test case during submission

This revision now requires changes to proceed.May 18 2017, 9:09 PM
RaspberryRye edited edge metadata.
RaspberryRye edited the test plan for this revision. (Show Details)

Added Requested Revisions.

JoshStrobl requested changes to this revision.May 19 2017, 8:42 AM
JoshStrobl added inline comments.
package.yml
19–20

Just needs to be chmod -R 00644 $installdir/usr/share/icons/*

This revision now requires changes to proceed.May 19 2017, 8:42 AM
RaspberryRye updated this revision to Diff 280.May 19 2017, 7:27 PM
RaspberryRye edited edge metadata.

Updated as requested.

ikey accepted this revision.May 22 2017, 5:34 PM
ikey added a subscriber: ikey.

LGTM

Closed by commit R3461:8eeaa004b8c1: Initial Commit of Numix Square Icon Theme Fixes T3676 (authored by Kayla Manchette <k.manchette1@email.com>, committed by ikey). · Explain WhyMay 22 2017, 5:34 PM
This revision was automatically updated to reflect the committed changes.