Change from most recent commit of xpad-noone to the tagged version of xpad-noone. This corresponds to the same commit, but the dev has added a tagged release.
Details
- Reviewers
Staudey - Group Reviewers
Triage Team
- Unplug the dongle and install xone. Run sudo xone-get-firmware.sh to install proprietary firmware.
- Plug in the dongle and pair a controller.
- Launch an app and make sure the controller works.
Diff Detail
- Repository
- R5643 xone
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 4845 Build 4845: arc lint + arc unit
Event Timeline
So this would have to be rebased/rebuilt for the kernel update, but I'm not sure we necessarily want this. It doesn't functionally change it, and the packaging script looks cleaner without.
I know the upstream maintainer went through the effort of tagging a release for our sake, but still. But if you want to rebase it I'm fine with including the tagged source anyway.
I don't think there's any need for this to be included. I was actually pretty surprised that xpad-noone wasn't automatically decompressed like xone; perhaps this is an improvement that could be made to the tooling. The current packaging is definitely a bit nicer.
Feel free to drop this diff at your discretion.
Okay, then I'll abandon this diff, thanks!
I agree with the tooling comment. Rarely do we *not* want something to be decompressed.