Page MenuHomeSolus

Change to tagged release of xpad-noone
AbandonedPublic

Authored by infinitymdm on Jan 18 2023, 2:45 AM.
Tags
None
Referenced Files
F11007301: D13949.diff
Tue, Aug 1, 7:00 PM
F10866350: D13949.diff
Jun 17 2023, 3:07 PM
F10795609: D13949.id34033.diff
May 27 2023, 9:49 PM
F10795371: D13949.diff
May 27 2023, 8:37 PM
F10746432: D13949.id34033.diff
May 15 2023, 10:50 AM
F10746430: D13949.id.diff
May 15 2023, 10:50 AM
F10723777: D13949.diff
May 7 2023, 7:46 AM
F10716678: D13949.diff
May 4 2023, 1:27 PM
Subscribers

Details

Reviewers
Staudey
Group Reviewers
Triage Team
Summary

Change from most recent commit of xpad-noone to the tagged version of xpad-noone. This corresponds to the same commit, but the dev has added a tagged release.

Test Plan
  • Unplug the dongle and install xone. Run sudo xone-get-firmware.sh to install proprietary firmware.
  • Plug in the dongle and pair a controller.
  • Launch an app and make sure the controller works.

Diff Detail

Repository
R5643 xone
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4845
Build 4845: arc lint + arc unit

Event Timeline

So this would have to be rebased/rebuilt for the kernel update, but I'm not sure we necessarily want this. It doesn't functionally change it, and the packaging script looks cleaner without.

I know the upstream maintainer went through the effort of tagging a release for our sake, but still. But if you want to rebase it I'm fine with including the tagged source anyway.

Staudey requested changes to this revision.May 4 2023, 7:46 PM
This revision now requires changes to proceed.May 4 2023, 7:46 PM

I don't think there's any need for this to be included. I was actually pretty surprised that xpad-noone wasn't automatically decompressed like xone; perhaps this is an improvement that could be made to the tooling. The current packaging is definitely a bit nicer.

Feel free to drop this diff at your discretion.

Okay, then I'll abandon this diff, thanks!

I agree with the tooling comment. Rarely do we *not* want something to be decompressed.