Looks good to me for the most part. Just one minor thing, since we will deprecate python-pysrt after this inclusion anyway, and a replaces is more sensible in that light IMO.

package.yml
12	I think we should better change this to a `replaces :` (also get rid of the `\|` or it won't work)

P.S. I've created a PR for the deprecation of python-pysrt while I was at it

https://github.com/getsolus/solus-sc/pull/191

Staudey requested changes to this revision.Jan 10 2023, 8:34 PM

This revision now requires changes to proceed.Jan 10 2023, 8:34 PM

Change conflicts to replaces

Harbormaster completed remote builds in B4825: Diff 33998.Jan 12 2023, 3:42 AM

infinitymdm marked an inline comment as done.Jan 12 2023, 3:43 AM

LGTM, thanks!

It just seems that you didn't rebuild after the last change, or didn't include the updated pspec, but I fixed that locally instead of starting another round of review ?

This revision is now accepted and ready to land.Jan 13 2023, 1:54 PM

Closed by commit R5683:5f2debd6c838: Initial inclusion of python-srt (authored by infinitymdm, committed by Staudey). · Explain WhyJan 13 2023, 1:55 PM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R5683:5f2debd6c838: Initial inclusion of python-srt.