Page MenuHomeSolus

Include nextcloud-nemo extension
ClosedPublic

Authored by palto42 on Jan 7 2023, 3:30 PM.
Tags
None
Referenced Files
F11004710: D13921.diff
Tue, Aug 1, 3:10 AM
F10967502: D13921.diff
Thu, Jul 20, 9:48 AM
F10868810: D13921.diff
Jun 18 2023, 12:47 AM
F10857480: D13921.diff
Jun 15 2023, 5:14 AM
F10844169: D13921.id33959.diff
Jun 10 2023, 8:13 PM
F10841646: D13921.id33963.diff
Jun 10 2023, 8:15 AM
F10745448: D13921.id.diff
May 15 2023, 5:47 AM
F10745444: D13921.id33959.diff
May 15 2023, 5:46 AM
Subscribers

Details

Summary

Include the nemo-nextcloud extension since Solus added the nemo package to its repository.

Signed-off-by: Matthias Homann <palto@mailbox.org>

Test Plan

Build and installed locally, works the same as nextcloud-nautilus.

Diff Detail

Repository
R3740 nextcloud-client
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

EbonJaeger added a subscriber: EbonJaeger.

Even though this package doesn't do this for Nautilus, let's split the extension into its own package using a pattern. This is a good idea because the extension has to depend on the nautilus-extension package so the Python bindings are present. See GtkHash for an example.

This revision now requires changes to proceed.Jan 7 2023, 4:26 PM

Hi @EbonJaeger , I have no objections to split the package, but it's not fully clear to me if you suggest to just split the extension for nemo or all (nautilus, nemo and caja).
The current package also contains the extension for caja, only dolphin has it's own sub-package nextcloud-client-dolphin-integration (but this contains more than one Python script).

Regarding the dependencies, the current package has no dependency on nautilus-python, the other sub-packages would depend on nemo-extensions or caja-extensions.

Didn't realize Caja was also included... At this point it's not worth the extra effort. Looks good to me. Thanks!

This revision is now accepted and ready to land.Jan 7 2023, 8:32 PM
This revision was automatically updated to reflect the committed changes.