Paths

Table of Contentst

Differential D13890

Update vmpk to 0.8.8
ClosedPublic
Actions

Authored by stalebrim on Dec 25 2022, 6:36 PM.

Tags

None

Referenced Files

	F11004902: D13890.diff
	Tue, Aug 1, 4:15 AM

	F10868609: D13890.id33905.diff
	Jun 18 2023, 12:04 AM

	F10867200: D13890.diff
	Jun 17 2023, 7:12 PM

	F10867130: D13890.id33900.diff
	Jun 17 2023, 6:56 PM

	F10865975: D13890.id33896.diff
	Jun 17 2023, 1:36 PM

	F10858283: D13890.diff
	Jun 15 2023, 2:41 PM

	F10856958: D13890.diff
	Jun 15 2023, 2:37 AM

	F10746855: D13890.id.diff
	May 15 2023, 1:05 PM

View All 13 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

R4642:373551173177: Update vmpk to 0.8.8

Summary

Changelogs:
0.8.6 | 0.8.7 | 0.8.8
0.8.3 | 0.8.4 | 0.8.5

Depends on D13889

Test Plan

Verify it makes sounds
Test MIDI input with MIDI hardware

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stalebrim created this revision.Dec 25 2022, 6:36 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 25 2022, 6:36 PM

stalebrim requested review of this revision.Dec 25 2022, 6:36 PM

Harbormaster completed remote builds in B4765: Diff 33896.Dec 25 2022, 6:36 PM

stalebrim edited the summary of this revision. (Show Details)Dec 25 2022, 6:37 PM

stalebrim added a parent revision: D13889: Update drumstick to 2.7.2.

Staudey requested changes to this revision.Dec 25 2022, 7:51 PM

Staudey added a subscriber: Staudey.

Staudey added inline comments.

package.yml
11	I think the following build deps should be enough: - pkgconfig(Qt5Svg) - pkgconfig(Qt5UiTools) - pkgconfig(drumstick-rt) - docbook-xml `xcb` and `Qt5X11Extras` no longer seem to be used. `Qt5Widgets` is part of `qt5-base-devel`, which gets pulled in by the other Qt5 dependencies (and bringing the deps into the proper order \| S before U, and A-Z before a-z) The rundeps should no longer be necessary at all as qt5-x11extras is no longer used (see above), and `drumstick` gets detected as a rundep automatically at the end of the build

This revision now requires changes to proceed.Dec 25 2022, 7:51 PM

Staudey added inline comments.Dec 25 2022, 8:00 PM

package.yml
17	You can also get rid of the period here I just saw

Get rid of unnecessary periods and deps

Harbormaster completed remote builds in B4769: Diff 33900.Dec 25 2022, 8:44 PM

Done

LGTM now, thanks!

This revision is now accepted and ready to land.Dec 26 2022, 2:05 AM

Closed by commit R4642:373551173177: Update vmpk to 0.8.8 (authored by stalebrim, committed by Staudey). · Explain WhyDec 26 2022, 2:08 AM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R4642:373551173177: Update vmpk to 0.8.8.

Revision Contents
Changeset List

Path

Size

3 lines

abi_used_symbols

219 lines

18 lines

pspec_x86_64.xml

8 lines

Diff 33905

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...