Paths

Table of Contentst

Differential D13878

Initial inclusion of bandwhich
ClosedPublic
Actions

Authored by nazar on Dec 18 2022, 5:47 AM.

Tags

None

Referenced Files

	F11054431: D13878.id33873.diff
	Fri, Aug 11, 12:47 AM

	F11054430: D13878.id.diff
	Fri, Aug 11, 12:47 AM

	F11054429: D13878.id33866.diff
	Fri, Aug 11, 12:47 AM

	F11054428: D13878.id33874.diff
	Fri, Aug 11, 12:47 AM

	F11038162: D13878.diff
	Wed, Aug 9, 10:08 PM

	F11004608: D13878.diff
	Tue, Aug 1, 2:43 AM

	F10902744: D13878.id33874.diff
	Jul 5 2023, 5:56 AM

	F10902743: D13878.id33866.diff
	Jul 5 2023, 5:56 AM

View All 22 Files

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T10148: bandwhich

Commits

R5664:7fe6ef68af8b: Initial inclusion of bandwhich

Summary

resolves T10148

Test Plan

run and check processes making IP traffic

Diff Detail

Repository

R5664 bandwhich

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nazar created this revision.Dec 18 2022, 5:47 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptDec 18 2022, 5:47 AM

nazar requested review of this revision.Dec 18 2022, 5:47 AM

Harbormaster completed remote builds in B4747: Diff 33866.Dec 18 2022, 5:47 AM

algent requested changes to this revision.Dec 18 2022, 4:45 PM

algent added a subscriber: algent.

algent added inline comments.

package.yml
16	Why is this neccessary?
19	`-D -m 00755` can be shortened to `-Dm00755`. Also please add the man pages. `install -Dm00644 docs/bandwhich.1 -t $installdir/usr/share/man/man1/`

This revision now requires changes to proceed.Dec 18 2022, 4:45 PM

cargo update``` is there because of dependency compile error. It is a workaround for new-ish rust and rather old cargo.lock in this release. It'll be fixed upstream with new release and updated dependencies. See  https://github.com/imsnif/bandwhich/issues/258

package.yml
16	it's because of build error unless cargo.lock is updated. It'll be fixed upstream I beleave, but for now it is a workaround to avoid compile-time error. See https://github.com/imsnif/bandwhich/issues/258

include man pages

Harbormaster completed remote builds in B4751: Diff 33873.Dec 18 2022, 5:31 PM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 18 2022, 5:47 PM

Closed by commit R5664:7fe6ef68af8b: Initial inclusion of bandwhich (authored by nazar, committed by algent). · Explain WhyDec 18 2022, 5:47 PM

This revision was automatically updated to reflect the committed changes.

algent added a commit: R5664:7fe6ef68af8b: Initial inclusion of bandwhich.

Revision Contents
Changeset List

Path

Size

5 lines

1 line

4 lines

abi_used_symbols

137 lines

19 lines

pspec_x86_64.xml

35 lines

Diff 33874

MAINTAINERS.md

Loading...

Makefile

Loading...

abi_used_libs

Loading...

abi_used_symbols

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...