Page MenuHomeSolus

Update TLP to 1.5.0
ClosedPublic

Authored by palto42 on Dec 4 2022, 9:49 AM.
Tags
None
Referenced Files
F11004712: D13835.diff
Tue, Aug 1, 3:10 AM
F10936146: D13835.id33826.diff
Thu, Jul 13, 1:25 AM
F10936145: D13835.id33761.diff
Thu, Jul 13, 1:25 AM
F10936144: D13835.id33760.diff
Thu, Jul 13, 1:25 AM
F10878793: D13835.diff
Jun 21 2023, 2:09 PM
F10843280: D13835.id33826.diff
Jun 10 2023, 5:23 PM
F10842312: D13835.id33838.diff
Jun 10 2023, 11:23 AM
F10842099: D13835.id33760.diff
Jun 10 2023, 10:16 AM
Subscribers

Details

Summary

This update fixes T9939

Changelog:

  • Reduced Solus customization of tlp.conf
    • Let the user decide on more non-default tweaks
    • Most of the customization was for legacy version/kernel or default in 1.5.0 anyway
  • Removed superseded patch of tlp.in (included in 1.5.0)
  • 1.5.0
  • 1.4.0

Signed-off-by: Matthias Homann <palto@mailbox.org>

Test Plan
  • Built and installed locally
  • Used on AC and BAT
  • Checked TLP status on CLI

Diff Detail

Repository
R3046 tlp
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

palto42 updated this revision to Diff 33760.

updated summary

removed unnecessarey change of patch file 001

Staudey requested changes to this revision.Dec 13 2022, 7:54 PM
Staudey added a subscriber: Staudey.

To stay on the safe side, user-experience-wise, I'd keep our custom settings when it comes to WiFi, USB and sound devices. I can't rule out that all of these work perfectly know, but I'd rather not take the chance of them negatively impacting users in surprising ways. Many just install tlp because it's recommended online, but will not think of it as a suspect when their WiFi or sound doesn't work properly a bit further down the road, leading to frustration and hard to nail-down issues in support channels.

Most of the other setting changes are either neutral, slight improvements or already the default anyway.

files/0002-enable_default_settings_in_conf.patch
168

Keep this.

183

Keep this.

224

Keep this.

This revision now requires changes to proceed.Dec 13 2022, 7:54 PM

address requested changes: re-added some tlp.conf customisation

Addressed the requested changes.
Added Solus customization details in the package description.

Staudey edited the summary of this revision. (Show Details)
Staudey requested changes to this revision.Dec 14 2022, 8:59 PM

I don't feel like we should put such a huge emphasis on our custom settings right in the package description. The old one was fine. We customize most of our packages in one way or another; in some cases (e.g. kernel) there are so many customizations that it would turn the description into a 10 min read.

package.yml
10–13

We won't include notes about our customized settings in every package description. That way lies madness.

This revision now requires changes to proceed.Dec 14 2022, 8:59 PM
package.yml
10–13

Hi @Staudey , I think we should at least provide a small hint that the package doesn't come with standard TLP defaults. Users install this package and expect some power savings which they might not get due to the modifications and they may not expect that this is due to custom Solus changes. Then they might just be disappointed and remove the package. What's the harm of telling the user some extra info?
If you don't what that level of detail, I can rephrase more generic like "Note that Solus changes some TLP defaults."

I don't really care too much either way to hold up this package update even longer.

Going to land it with your updated description. Thanks!

This revision is now accepted and ready to land.Dec 15 2022, 6:24 PM
This revision was automatically updated to reflect the committed changes.