Page MenuHomeSolus

Update sqlite3 to 3.40.0
ClosedPublic

Authored by Icosahunter on Nov 30 2022, 1:47 AM.
Tags
None
Referenced Files
F11053807: D13822.id33780.diff
Thu, Aug 10, 11:58 PM
F11053806: D13822.id.diff
Thu, Aug 10, 11:58 PM
F11053805: D13822.id33731.diff
Thu, Aug 10, 11:58 PM
F11037980: D13822.diff
Wed, Aug 9, 9:38 PM
F10914073: D13822.diff
Jul 8 2023, 12:44 AM
F10890820: D13822.id33780.diff
Jun 28 2023, 5:24 PM
F10888766: D13822.id33731.diff
Jun 27 2023, 7:42 AM
F10884647: D13822.diff
Jun 25 2023, 1:42 AM
Subscribers

Details

Summary

Update sqlite3 to 3.40.0
Resolves T10441

Changelogs:

Test Plan

Create database in sqlitebrowser and add some data, open the database in CLI sqlite3 with "sqlite3" then ".open [file name]", show the data with "SELECT * FROM [table name]"

Diff Detail

Repository
R2955 sqlite3
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Staudey requested changes to this revision.Dec 7 2022, 10:58 PM
Staudey added a subscriber: Staudey.

We're going to need a changelog / release notes, or a link to them.

This revision now requires changes to proceed.Dec 7 2022, 10:58 PM

We're going to need a changelog / release notes, or a link to them.

Here's the link to the 3.40 release notes.

https://www.sqlite.org/releaselog/3_40_0.html

Do I need to add that link in the summary or something Staudey or did you just need it for reference?

No, I don't only need it for my own reference (in that case I would've just looked for it myself ?) Every package version update needs either a full changelog (if short), summarized changelog, and/or link to changelog(s), in the summary. Sorry for not expressing that clearly enough before. I incorrectly assumed you were already aware of that particular aspect of packaging.

Please add one or more links to the changelog(s)/release notes covering the versions between 3.34.1 to (including) 3.40.0. (I guess the list of changes is far too big to put it into the summary directly)

Ok, no problem, I'll add those!

We're going to need a changelog / release notes, or a link to them.

Ok, the links are in there, let me know if I need to reformat them, it looked like there wasn't a standard for that whem providing links based on another recent update I saw.

We're going to need a changelog / release notes, or a link to them.

Ok, the links are in there, let me know if I need to reformat them, it looked like there wasn't a standard for that whem providing links based on another recent update I saw.

Yeah, no, like unfortunately a lot when it comes to formatting patches (and package.yml's) there's not necessarily a rule/standard here. Probably wouldn't hurt if we could at some point write additional documentation to that end (and first discuss and agree to some common standards).

FWIW in this case, or other cases when there are A LOT of changelog, I would be happy to accept a link to a single page, where all changelogs are listed, in this case for example https://www.sqlite.org/chronology.html (better if one can link directly to the relevant part of the page, which unfortunately doesn't seem to be possible here; that is, link directly to 3.40.0, so when new items are added it still leads you directly to where you want to look)

Since you've already put in the effort to link all separate changelogs, I've just taken the liberty of formatting it a bit differently (it's a huge collection of links, so I don't know if what I arrived at is necessarily better, I just preferred it a tiny bit).

I'm going to wait until after the sync to merge this, I think, to get some more testing in. Personally I've been using this patch for a week and haven't noticed any issues, but I don't use THAT many of the reverse dependencies on a regular basis.

We're going to need a changelog / release notes, or a link to them.

Ok, the links are in there, let me know if I need to reformat them, it looked like there wasn't a standard for that whem providing links based on another recent update I saw.

Yeah, no, like unfortunately a lot when it comes to formatting patches (and package.yml's) there's not necessarily a rule/standard here. Probably wouldn't hurt if we could at some point write additional documentation to that end (and first discuss and agree to some common standards).

FWIW in this case, or other cases when there are A LOT of changelog, I would be happy to accept a link to a single page, where all changelogs are listed, in this case for example https://www.sqlite.org/chronology.html (better if one can link directly to the relevant part of the page, which unfortunately doesn't seem to be possible here; that is, link directly to 3.40.0, so when new items are added it still leads you directly to where you want to look)

Since you've already put in the effort to link all separate changelogs, I've just taken the liberty of formatting it a bit differently (it's a huge collection of links, so I don't know if what I arrived at is necessarily better, I just preferred it a tiny bit).

I'm going to wait until after the sync to merge this, I think, to get some more testing in. Personally I've been using this patch for a week and haven't noticed any issues, but I don't use THAT many of the reverse dependencies on a regular basis.

Ok, sounds good, let me know if there's anything more I can do here!

This revision is now accepted and ready to land.Dec 10 2022, 11:31 PM
This revision was automatically updated to reflect the committed changes.