Change library from pysrt to srt
ClosedPublic
Actions

Authored by infinitymdm on Nov 11 2022, 1:46 AM.

Details

Reviewers

Staudey

Commits

R2972:a7c5b0ad3052: Change library from pysrt to srt

Summary

Patch subliminal to use srt instead of pysrt.

Since subliminal is the only package that depends on the apparently unmaintained pysrt library, this patch would allow us to deprecate pysrt and replace it with srt.
To be completely honest, I don't really use this sort of software. It needs thorough testing by someone who will actually use it.

Depends on T10431 python-srt.

Test Plan

Execute subliminal --help in terminal

Diff Detail

Repository

R2972 subliminal

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4585
Build 4585: arc lint + arc unit

Event Timeline

infinitymdm created this revision.Nov 11 2022, 1:46 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 11 2022, 1:46 AM

infinitymdm requested review of this revision.Nov 11 2022, 1:46 AM

Harbormaster completed remote builds in B4585: Diff 33577.Nov 11 2022, 1:46 AM

Bump release number

Harbormaster completed remote builds in B4586: Diff 33578.Nov 11 2022, 1:51 AM

Staudey awarded a token.Nov 11 2022, 5:00 PM

Marking this as "Request Changes", because python-srt is not accepted yet for inclusion, to avoid accidental landing.

This revision now requires changes to proceed.Nov 11 2022, 5:17 PM

infinitymdm edited the summary of this revision. (Show Details)Nov 11 2022, 7:01 PM

LGTM, thanks! It works just as well (or more accurately, just as badly) as with python-pysrt in my testing. Maybe we will have to get rid of subliminal altogether in the future, but this is definitely a workable solution for the time in-between now and then.

Staudey removed a reviewer: algent.Jan 13 2023, 1:58 PM

Staudey removed a reviewer: Triage Team.

This revision is now accepted and ready to land.Jan 13 2023, 1:58 PM

Closed by commit R2972:a7c5b0ad3052: Change library from pysrt to srt (authored by infinitymdm, committed by Staudey). · Explain WhyJan 13 2023, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Staudey added a commit: R2972:a7c5b0ad3052: Change library from pysrt to srt.